Skip to content

Conversation

Tobias-B-Besemer
Copy link
Contributor

No description provided.

Copy link
Member

@az0 az0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on line 135

<action command="winreg" path="HKCU\Software\Ashampoo\Ashampoo Burning Studio 19\DVD-Video Disc Project\MoviesPage" name="Path"/>
<action command="winreg" path="HKCU\Software\Ashampoo\Ashampoo Burning Studio 19\DVD-Video Disc Project\SaveDialog_authed.CMoviesPage.Movies" name="InitialDirectory"/>
<action command="winreg" path="HKCU\Software\Ashampoo\Ashampoo Burning Studio 19\Logs"/>
<action command="winreg" path="HKCU\Software\Ashampoo\Ashampoo Burning Studio 19\tempFilesv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of line 135 seems to be missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that! Was a c&p issue...

</option>
</cleaner>
<!--
Additionaly WinApp2.ini have this rules...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not compare this to the rules in Winapp2.ini, but here is a general comment. If the Winapp2.ini cleaner works or can be made to work, it's best not to translate it manually into a CleanerML file. One problem is each will have to be maintained, like when the application changes or new files are discovered.

A good reason to start a CleanerML file is if it is impossible for the Winapp2.ini cleaner to do a good job. For example, Winapp2.ini can't edit .ini files, edit json, do anything on Linux, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some reasons why I give the knowledge of my "Reverse Engineering" to the CleanerML Project and also think the WinApp2.ini data should be ported to CleanerML...
One reason is my experience with try to volunteering by WinApp2.ini: It was hard to get my changes in and they gave me the feeling, that they think they are "special" - and I don't want to fight for volunteering anymore!
Also: The data is now used by many other companies then Periform - e.g. Avira - and I don't like this!
Then: If we "convert" the data to CleanerML, we can split it into better categories like "logs", "temp", etc. what gives the user more control...
A other reason: IMHO users should be able to use BleachBit without WinApp2.ini!
We should have a "WinApp2.ini trimmer" for help to convert data to CleanerML, but I will fill a issue about that in the wishlist, later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants