handbrake.xml #231
Open
handbrake.xml #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
az0
reviewed
Mar 19, 2019
release/handbrake.xml
Outdated
| ...so we use %SystemDrive%\Program Files\ & %SystemDrive%\Program Files (x86)\... | ||
| --> | ||
| <value os="windows">%SystemDrive%\Program Files\HandBrake</value> | ||
| <value os="windows">%SystemDrive%\Program Files (x86)\HandBrake</value> |
There was a problem hiding this comment.
According to this Wikipedia article on Program Files, the directory name can be localized, so these paths may break on some systems. It's best to use Program Files environment variables instead.
Can Handbreak be installed in both the x86 and "regular"?
There was a problem hiding this comment.
32bit builds are no longer provided.
But were in the past...
There was a problem hiding this comment.
Would you please change the ProgramFiles here to be like BiglyBT?
There was a problem hiding this comment.
Done it already! Just didn't made a PR by now...
az0
requested changes
Mar 20, 2019
release/handbrake.xml
Outdated
| ...so we use %SystemDrive%\Program Files\ & %SystemDrive%\Program Files (x86)\... | ||
| --> | ||
| <value os="windows">%SystemDrive%\Program Files\HandBrake</value> | ||
| <value os="windows">%SystemDrive%\Program Files (x86)\HandBrake</value> |
There was a problem hiding this comment.
Would you please change the ProgramFiles here to be like BiglyBT?
|
Done it already! Just didn't made a PR by now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.