Skip to content

Fix to enable autocomplete or paste when countryCodeEditable is false #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

jonathancalb
Copy link

Fix for #328

@GarrettJMU
Copy link

@CapleaIonut-Alexandru @ionutmiftode @mimi26 @bl00mber any chance this will get merged soon? Pretty decent pain point.

@GarrettJMU
Copy link

@jonathancalb I'd also like to see what settings you used to get this to work. It's still not working when pointing at this commit using:

countryCodeEditable={false}
autocompleteSearch={true}

@jonathancalb
Copy link
Author

@GarrettJMU added in the demo the autocomplete case. You can test it there and see the settings I used in this PR. @bl00mber can we move this forward? We are using the library in a project and considering forking it because there is no response here. Thanks!

@GarrettJMU
Copy link

@jonathancalb so when I pointed to your project I'm still not getting Autocomplete working. I also tried cloning the repo and not getting it there either. Is there anything else I should be using/have? Would it be helpful if I included a screenshare?

@jonathancalb
Copy link
Author

@GarrettJMU do you have any addresses saved in your browser? It will get the mobile number you got saved there. If not it will not find anything to autocomplete.

@jonathancalb

This comment has been minimized.

@bl00mber bl00mber reopened this Feb 10, 2021
@bl00mber
Copy link
Owner

bl00mber commented Feb 10, 2021

Seems I cannot merge this since there are credentials hijacking.

@bl00mber bl00mber closed this Feb 10, 2021
@bl00mber
Copy link
Owner

bl00mber commented Mar 31, 2021

This is probably not working or breaking existing functionality, can anyone explain what the changes here are doing and how to test this? Why mainCode is excluded from the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants