Skip to content

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Aug 22, 2025

🎟️ Tracking

PM-23576 - Validate local KDF settings are correct when updating server KDF
PM-23277 - Upgrade KDF settings to minimums

📔 Objective

This adds forced KDF updates if the PBKDF2 iterations is below the minimum (600k). KDF updates can be performed without user interaction when unlocking the vault with a master password. Otherwise, there's a check on the vault list after syncing. In this flow, the user will have to input their master password before the update can proceed.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.91%. Comparing base (3cf5276) to head (e81760c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1880       +/-   ##
===========================================
- Coverage   88.63%   69.91%   -18.72%     
===========================================
  Files         810      260      -550     
  Lines       51093    11778    -39315     
===========================================
- Hits        45288     8235    -37053     
+ Misses       5805     3543     -2262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb1936196-786e-47e9-a816-c321e18721b3

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant