Fix for #80 #92
Open
Fix for #80 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewhyte
force-pushed
the
radio-btns-syn-keyboard
branch
from
669527d to
b5804dd
Compare
|
I've narrowed the scope of which inputs syn.typeable considers 'typeable'. This partially solves our issue. However, input[type=number] & input[type=email] still present a concern (as they don't support selectionStart) but should be selectable. I'm using a try/catch to handle that problem. @justinbmeyer: Let me know if you've got time to look this over at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for selectionStart throws an error in both Chrome and FF. Switched to using a try/catch to handle the conditional safely.