[bitnami/discourse] Allow for DISCOURSE_SMTP_DOMAIN to be set via docker #82421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ker-compose Signed-off-by: Stephan Hagemann <[email protected]>
|
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
Signed-off-by: Stephan Hagemann <[email protected]>
shageman
force-pushed
the
sh-discourse-domain-env-var
branch
from
16b5a42 to
e1e6c74
Compare
|
@carrodher does the new commit (with signing) look right? |
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change exposes the config option
smtp_domainas env variableDISCOURSE_SMTP_DOMAINBenefits
If the hostname doesn't match the email domain, SMTP providers might balk at sending messages. Set this setting to correct that.
Applicable issues
#35676
Additional information
https://meta.discourse.org/t/troubleshoot-email-on-a-new-discourse-install/16326