Skip to content

Conversation

patrickunterwegs
Copy link
Member

No description provided.

@rfc2822
Copy link
Member

rfc2822 commented Sep 15, 2025

It only affects the ktor package, so it should be fine :)

One thing I wonder: would it be possible to not duplicate the properties? Because they should be data classes and depend only on XML parsing.

@rfc2822
Copy link
Member

rfc2822 commented Sep 17, 2025

One thing I wonder: would it be possible to not duplicate the properties?

As far as I have seen, the files in the property package don't have okhttp dependencies. So I suggest to

  • move the properties to at.bitfire.dav4jvm.common.property (without duplicating them),
  • add the Ktor part (= classes with okhttp dependency) to at.bitfire.dav4jvm.ktor.* as planned and as this PR does.

What do you think?

@patrickunterwegs
Copy link
Member Author

Hi, basically it could be done, shouldn't be much effort anyway.
Why I would still hesitate doing that is the next step for Kotlin Multiplatform.

From my point of view it would make sense to adapt the Ktor version in a way that also the parser is Multiplatform compatible. If the properties are shared, another solution must be found about how to proceed when the XMLPullParser is replaced by another solution.
So I would rather prefer to build upon the ktor package and replace the parsing there with a Multiplatform compatible one. I wouldn't mind the shred properties for now, but then another approach must be found on how to deal with changes for Multiplatform compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants