Add unit tests #14
Add unit tests #14
Conversation
thunderbiscuit
force-pushed
the
test/add-unit-tests
branch
from
53bfa4c to
d751661
Compare
| Network.REGTEST | ||
| ) | ||
| val descriptor2: Descriptor = Descriptor( | ||
| "wpkh(tprv8ZgxMBicQKsPf2qfrEygW6fdYseJDDrVnDv26PH5BHdvSuG6ecCbHqLVof9yZcMoM31z9ur3tTYbSnr1WBqbGX97CbXcmp5H6qeMpyvx35B/86h/1h/1h/0/*)", |
There was a problem hiding this comment.
Since this is for WPKH I would think the path should be m/84 not m/86.
I am a bit surprised this worked.
There was a problem hiding this comment.
Ooops yep.
The reason why it works is that these bips are simply conventions. You can use any path you want. And this is what makes those strings dangerous to build manually; we see mistakes like this everywhere, even with very advanced bitcoin devs. This is why BDK developed the descriptor templates.
Good catch!
| Network.TESTNET | ||
| ) | ||
| val descriptor3: Descriptor = Descriptor( | ||
| "tr(tprv8ZgxMBicQKsPf2qfrEygW6fdYseJDDrVnDv26PH5BHdvSuG6ecCbHqLVof9yZcMoM31z9ur3tTYbSnr1WBqbGX97CbXcmp5H6qeMpyvx35B/86h/1h/1h/0/*)", |
There was a problem hiding this comment.
Should we make the actual string of the paths constants too. I imagine we will be repeating them every where maybe in new tests too. (Thinking out loud)
There was a problem hiding this comment.
Yeah I actually like that idea. Let me push some new stuff to potentially clean this up.
thunderbiscuit
force-pushed
the
test/add-unit-tests
branch
2 times, most recently
from
ccb0227 to
da92a03
Compare
thunderbiscuit
force-pushed
the
test/add-unit-tests
branch
from
da92a03 to
d9fa0ba
Compare
This is just to break the tests ice and add some unit tests. I'll rename the "Offline" tests since for now they will all be independent of any outside networks like Signet or Testnet 4.