BIP155: update status from Draft to Final #1933
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc BIP author @laanwj |
|
Thank you! Sounds good to me (either like this, or Final). About time, even, as BIP155 was introduced in bitcoin core version v0.21.0, and has been in use for almost 5 years. The only change i can imagine would be adding new network types, when they're needed. But those could be defined in a new BIP as well. That's no reason to keep it as Draft. |
jonatack
changed the title
BIP155 was deployed in Bitcoin Core version v0.21.0, and has been in use for almost 5 years. New networks may be added to the reserved network IDs table when they're needed, either in this BIP or in a new one. If BIP3 is activated, I think BIP155 would become Deployed. Co-authored-by: Murch <[email protected]> Co-authored-by: laanwj <[email protected]>
jonatack
force-pushed
the
2025-08-update-BIP155-status
branch
from
ac642a5 to
862d9ca
Compare
|
Updated the change to Final (thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP155 was deployed in Bitcoin Core version v0.21.0, and has been in use for almost 5 years.
New networks may be added to the reserved network IDs table, when they're needed, either in this BIP (seems fine) or in a new one.
If BIP3 is activated, I think BIP155 would become Deployed.