Skip to content

BIP352: fix byte unpacking and avoid mutable default argument #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

BIP352: fix byte unpacking and avoid mutable default argument #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f989b
Update bitcoin_utils.py
fifalodm Aug 8, 2025
948f137
Update reference.py
fifalodm Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions bip-0352/bitcoin_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,11 @@ def deser_txid(txid: str):


def deser_compact_size(f: BytesIO):
view = f.getbuffer()
nbytes = view.nbytes;
view.release()
if (nbytes == 0):
return 0 # end of stream
b = f.read(1)
if not b:
return 0 # end of stream

nit = struct.unpack("<B", f.read(1))[0]
nit = struct.unpack("<B", b)[0]
if nit == 253:
nit = struct.unpack("<H", f.read(2))[0]
elif nit == 254:
Expand Down
6 changes: 4 additions & 2 deletions bip-0352/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import hashlib
import json
from typing import List, Tuple, Dict, cast
from typing import List, Tuple, Dict, cast, Optional
from sys import argv, exit
from functools import reduce
from itertools import permutations
Expand Down Expand Up @@ -152,7 +152,9 @@ def create_outputs(input_priv_keys: List[Tuple[ECKey, bool]], outpoints: List[CO
return list(set(outputs))


def scanning(b_scan: ECKey, B_spend: ECPubKey, A_sum: ECPubKey, input_hash: bytes, outputs_to_check: List[ECPubKey], labels: Dict[str, str] = {}) -> List[Dict[str, str]]:
def scanning(b_scan: ECKey, B_spend: ECPubKey, A_sum: ECPubKey, input_hash: bytes, outputs_to_check: List[ECPubKey], labels: Optional[Dict[str, str]] = None) -> List[Dict[str, str]]:
if labels is None:
labels = {}
G = ECKey().set(1).get_pubkey()
ecdh_shared_secret = input_hash * b_scan * A_sum
k = 0
Expand Down