Skip to content

Conversation

@CodeByDrescher
Copy link
Contributor

What new features does this PR implement?
Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

Updates BioSimulators to use pyproject.toml configuration, which will help in the long term keep dependencies up to date.

Does this PR introduce any additional changes?

  • Project no longer has requirements.txt or similar, in exchange for pyproject.toml

How have you tested this PR?
biosimulators_test_suite successfully runs as previously, against both new and old simulators.

Additional information
note that python3.10 is currently the only version that works with BSTS, keeping in mind that when RBApy is fixed, it may not support python3.11+

Copy link

@AlexPatrie AlexPatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 98.08917% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.88%. Comparing base (5683d17) to head (3b16e88).
Report is 44 commits behind head on dev.

Files with missing lines Patch % Lines
biosimulators_test_suite/config.py 94.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #72   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          20       20           
  Lines        2551     2556    +5     
=======================================
+ Hits         2497     2502    +5     
  Misses         54       54           
Flag Coverage Δ
unittests 97.88% <98.08%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeByDrescher CodeByDrescher merged commit e8999c5 into dev Sep 19, 2024
@CodeByDrescher CodeByDrescher deleted the poetry-build branch September 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants