[ENH] SliderGraph: thicker threshold line #7091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7091 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 335 335
Lines 73916 73928 +12
=======================================
+ Hits 65638 65655 +17
+ Misses 8278 8273 -5 🚀 New features to boost your workflow:
|
BlazZupan
changed the title
janezd
reviewed
May 23, 2025
Orange/widgets/utils/slidergraph.py
Outdated
| ev : HoverEvent | ||
| The hover event from pyqtgraph | ||
| """ | ||
| if not hasattr(ev, 'isEnter'): # Add check for event type |
Contributor
There was a problem hiding this comment.
Can this check ever fail? Also, docstring declares this is a HoverEvent.
Contributor
There was a problem hiding this comment.
If you really need to check this, use if not isinstance(ev, HoverEvent).
Orange/widgets/utils/slidergraph.py
Outdated
| self._line.setPen(mkPen(self.palette().text().color(), width=2)) | ||
|
|
||
| # Set up hover state handling | ||
| self._line.hoverEvent = self._handle_hover # Changed from lambda to direct method reference |
Contributor
There was a problem hiding this comment.
I do not understand the comment.
Also, I'd prefer deriving a new class from InfiniteLine and override the hoverEvent method. Monkey-patching is not very pythonic.
Contributor
Author
There was a problem hiding this comment.
done, new class introduced
Orange/widgets/utils/slidergraph.py
Outdated
| # Set up hover state handling | ||
| self._line.hoverEvent = self._handle_hover # Changed from lambda to direct method reference | ||
|
|
||
| # Initial pen style |
BlazZupan
force-pushed
the
thicker-slider
branch
from
ed44dc4 to
dd2d1f6
Compare
BlazZupan
force-pushed
the
thicker-slider
branch
from
dd2d1f6 to
bfb7c28
Compare
BlazZupan
force-pushed
the
thicker-slider
branch
from
ddf389d to
42a096c
Compare
BlazZupan
force-pushed
the
thicker-slider
branch
from
feed758 to
df5114a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The vertical bar in the graphs such as scree plot (PCA) is almost invisible on the computer screen, and invisible when using a projector:
Description of changes
The bar is now thicker, and also more prominent (thick blue) when hovering.
Includes