Skip to content

Conversation

@Salonso1602
Copy link
Contributor

@Salonso1602 Salonso1602 commented May 24, 2024

Resolves

https://focusuy.atlassian.net/browse/BMC2-1068

Dependencies

#20

How to test

  • Go to actions
  • Run Tests workflow from this branch

What to expect

  • All tests pass as expected

Notes

Linux may still have the SEGFAULT error when you get down to testing

@Salonso1602 Salonso1602 self-assigned this May 24, 2024
@Salonso1602 Salonso1602 force-pushed the 1068-ralonso branch 5 times, most recently from 99ec6ca to 1b77ae4 Compare May 27, 2024 16:49
@joaquin-urrisa
Copy link
Contributor

I noticed that the tests are currently failing across all builds (see the latest run). I understand that Linux fails due to a known bug, whereas Mac and Windows fail due to the bridge version. Wasn't the bridge removed and now needs to be installed independently? (I saw that the PR for ticket 1050 was merged.)

Additionally, I noticed that you added the staging_dirs.txt.in file. I see it's referenced in both the CMakeLists.txt and the workflow file. I’m not entirely sure how it’s being used or what role it plays in the build process. Could you clarify?

@Salonso1602
Copy link
Contributor Author

I noticed that the tests are currently failing across all builds (see the latest run). I understand that Linux fails due to a known bug, whereas Mac and Windows fail due to the bridge version. Wasn't the bridge removed and now needs to be installed independently? (I saw that the PR for ticket 1050 was merged.)

That is true, I must revise how the Bridge should be fetched in this PR now that we use a prebuilt bridge

Additionally, I noticed that you added the staging_dirs.txt.in file. I see it's referenced in both the CMakeLists.txt and the workflow file. I’m not entirely sure how it’s being used or what role it plays in the build process. Could you clarify?

the staging dirs txt file is a way of keeping track between actions of where the libs were built and staged so they can be added to PATH, in hindsight it may not be the best solution nor do I have the context how It came to be.
I will give it some reading and get back t you

@felipemoran93 felipemoran93 marked this pull request as ready for review August 28, 2024 16:32
@felipemoran93 felipemoran93 changed the base branch from develop-1.1.0 to develop-1.2.0 September 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants