Optional menu button #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works, the icon type issue was fixed in 71e2377#diff-39f15dcb5540310cc645f61cf2724af7R70, so @binggg will need to sort a merge conflict out here. |
|
There shouldn't be a merge conflict, as best I can tell. The issue I mentioned above is that I misread the purpose of navIconName - I thought it was arbitrary, so I passed in "foo" and it ended up being predictably broken :) |
|
👍 |
|
I added this over at https://github.com/material-react-native/mrn/blob/master/lib/Toolbar.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #19, this only creates a menu button if navIconName is defined.
However, I noticed a bug where you don't get an icon if the navIconName is named anything other than "menu", which doesn't seem to be as intended. I can fix that, but it might be best done in a different pull request since it could break the current examples.