Preserves pre-disabled elements with hx-disabled-elt on other element #3443
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StabbarN
commented
Sep 24, 2025
| forEach(disabled, function(disabledElement) { | ||
| const internalData = getInternalData(disabledElement) | ||
| if (internalData.requestCount === 0) { | ||
| if (internalData.requestCount === 0 && disabledElement.hasAttribute('data-disabled-by-htmx')) { |
There was a problem hiding this comment.
Test multiple requests with same disabled elt are handled properly will fail without this change.
StabbarN
commented
Sep 24, 2025
| b2.hasAttribute('disabled').should.equal(true) | ||
| b2.hasAttribute('data-disabled-by-htmx').should.equal(false) | ||
| b1.click() | ||
| b2.hasAttribute('disabled').should.equal(true) |
There was a problem hiding this comment.
Suggestion: verify that data-disabled-by-htmx isn't set? That is, adding a line b2.hasAttribute('data-disabled-by-htmx').should.equal(false).
However, data-disabled-by-htmx isn't tested anywhere in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Elements with
hx-disabled-eltthat were already disabled before sending request will now keep the disabled attribute after server has responded or timed out.A good chunk of the users are probably thinking that this doesn't matter because their html will always swap after request has completed but if they have set
htmx.config.timeoutthe request can time out and elements that are supposed to be disabled will not be disabled anymore.The attribute
data-disabled-by-htmxisn't set if the element already was disabled.Questions
Should I add a note to the documentation https://htmx.org/attributes/hx-disabled-elt/? Something like "Already disabled elements will not be affected"?
Corresponding issue: #3437
Testing
Test added:
preserve pre-disabled elements.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded