feat: add hold as a trigger event modifier #3442
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.
adds hold as a trigger event
Corresponding issue:
None, I wanted to create a hold-to-click interaction and realized how common of a pattern it is, so I decided to take a stab at upstreaming it into HTMX
old PR :: #3438
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
I tried to test as many edge cases as I could, if any reviewer comes up with more, I can try adding those too. :)
Checklist
master
for website changes,dev
for source changes)npm run test
) and verified that it succeeded