Allow custom hx-prompt dialogs
#3377
Conversation
src/htmx.js
Outdated
| if (confirmed === undefined) { | ||
| const issueRequest = function(skipConfirmation) { | ||
| return issueAjaxRequest(verb, path, elt, event, etc, !!skipConfirmation) | ||
| return issueAjaxRequest(verb, path, elt, event, etc, skipConfirmation) |
There was a problem hiding this comment.
without this boolean conversion the documented default behaviour will be lost
// 3. Manually issue the request when you are ready
evt.detail.issueRequest(); // or evt.detail.issueRequest(true) to skip the built-in window.confirm()
});
it is expected that users will call issueRequest() with no input or (false) and it will then continue with the request after you have prevented the original request and if you pass undefined or false it converts this into boolean false and performs the normal confirm dialog action after you have had a chance to do your own handling. If you pass in (true) it will just do the request with no more confirm as you have already done it your own way somehow.
So we can't just change this with this simple change without breaking existing behaviour.
There was a problem hiding this comment.
Well then all that needs to be done to preserve existing behavior is to ensure that any value other than true or a string gets converted to false, right?
Description
This PR closes issue #3376, and allows users to create custom
hx-promptdialogs in exactly the same way we makehx-confirmdialogs.To do this, all I had to do was update the input type of
issueRequest()to accept astring|falsevalue rather thanboolean.Corresponding issue: #3376
Testing
I tested this with a custom Alpine.js modal, and it worked as expected. If I get traction on this, I will provide a full, working example (for
hx-confirmandhx-prompt.Please explain how you tested this change manually, and, if applicable, what new tests you added. If you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded(Having trouble testing, running on nixos).