Skip to content

Fix various small problems #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix various small problems #367

wants to merge 3 commits into from

Conversation

janEbert
Copy link
Collaborator

Problems:

  • BERT/T5 dataset handles already corrupted indices incorrectly.
  • GPT tokenizer vocab size does not include special tokens.
  • In Eval Harness evaluation, the last token of the target is unconditionally truncated. This results in wrong evaluation metrics and is actually not such a small problem.

This PR fixes these issues. Since the changes are so small, I didn't bother creating 3 PRs.

@janEbert
Fix covered index skipping
ce3f6c0
@janEbert
Fix GPT tokenizer vocab size query
f7c583f 
Did not include additional special tokens.
@janEbert
Do not remove last token
cfd6374 
This corrupts the targets. There is no good reason for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janEbert