Make reflection usages work more easily in Java 17+ #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix compile errors.
With Java 17+, java.lang.reflect functions do not work on modularized code (including core Java library code!) unless the corresponding package of the containing module has been explicitly opened with a --add-opens VM argument. Or unless we hack around it using the SciJava App Launcher's ReflectionUnlocker.
|
Ach, I forgot that pom-scijava 41.1.0 was not actually a real thing. 😅 This PR will be useful once pom-scijava 42.0.0 is released, though... so for now, converting to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch invokes SciJava's
ReflectionUnlockeras appropriate, to reduce the need for passing--add-opensflags when running code within this project. With this change, only one flag should be required:--add-opens=java.base/java.lang=ALL-UNNAMED, which is the flag that gives permission to theReflectionUnlockerto use reflection to do its thing. :laugh:It also updates to the latest release of pom-scijava, as well as updating the copyright blurb year to 2025.