This repository was archived by the owner on Jan 7, 2020. It is now read-only.
Update database.pp: Remove output of plain-text passwords to screen and puppet console #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all - great module, very useful! We are using puppet enterprise in an environment where passwords are not generally known by all team members. When running the puppet agent to install oracle, the database.pp causes the system passwords to be output in plain-text to the puppet console. In our environment this discloses information to people who do not need to know the passwords but do need to view server status and information on the puppet console. The most important part of this is the "show_diff" setting which prevents the console output. For 'replace=>false': We have later on added code to copy /dev/null over the response file so that it is not left on the server holding the plain-text passwords. I'm not sure if this was the best fix but we needed something that didn't cause the file to be recreated on the next puppet run.
|
Thanks Sarah. I will take a look at it, In chef template resource you got a sensitive attribute. there should be something in puppet to hide this. cheers Edwin |
|
what if we set loglevel on the file resource to warning or err . this should not display anything until there is something wrong. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all - great module, very useful - thank you!
We are using puppet enterprise in an environment where passwords are not generally known by all team members. When running the puppet agent to install oracle, the database.pp causes the system passwords to be output in plain-text to the puppet console. In our environment this discloses information to people who do not need to know the passwords but do need to view server status and information on the puppet console.
The most important part of this update is the "show_diff" setting which prevents the console output.
For 'replace=>false': We have later on added code to copy /dev/null over the response file so that it is not left on the server holding the plain-text passwords. I'm not sure if this was the best fix but we needed something that didn't cause the file to be recreated on the next puppet run. Out change for this is outside the scope of oradb so I'm not sure the best file to change in oradb
Best Regards
Sarah