-
-
Notifications
You must be signed in to change notification settings - Fork 77
fix: more stable packaging #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Signed-off-by: Sora Morimoto <[email protected]>
@bgub please check on this |
@smorimoto @andriiholovan I appreciate the PR, but I have a few concerns. I like the simplicity of merging configurations into one, but I feel that it "undoes" the purpose of Eta v4. The only change in Eta v4 compared to v3 is that it's ESM-only, because I'm trying to help the ecosystem move forward. Additionally, making a CJS version of |
Closes #330
This PR updates tsdown configuration to use tsdown's Auto-Generating Package Exports to support more stable packaging. In addition, we support dual ESM and CJS packages. To achieve this, we've moved away from the node and browser platform configuration and instead use a single neutral platform, marking the node-related dependencies as external dependencies so that we don't have two duplicate tsdown configurations. There is no impact at runtime.