Improve error handling and prevent panics during file processing #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added clippy lints to deny unwrap_used and expect_used - Updated configuration loading in src/config.rs to use Result types - Fixed database operations in src/database.rs and src/datasets/as2org.rs - Improved RPKI validator error handling in src/datasets/rpki/ - Enhanced time parsing with fallback values in src/time.rs - Updated CI workflow to include formatting and clippy checks - Core library now passes clippy --lib with no warnings - Binary retains some unwraps for CLI error handling but core is safe
- Fixed panic when remote file download fails during search operations - Replaced unwrap() with proper error handling in filters.to_parser() calls - Failed files now log error and continue with remaining files in batch - Parallel processing continues uninterrupted when individual files fail - Resolves thread panic that caused entire search process to halt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unwrap()/expect()calls with proper error handling throughout the codebaseKey Changes
Resulttypes with descriptive error messagesFiles Modified
src/config.rs,src/database.rs,src/datasets/src/bin/monocle.rsunwrap_usedandexpect_usedCore library now passes clippy checks with no warnings and builds successfully.
Resolves #75