Skip to content

Added packaging with CPack and generation of pkg-config. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Added packaging with CPack and generation of pkg-config. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f9845cd
Added metadata for the project in the format available for CPack.
KOLANICH Jul 22, 2021
a795de2
Added CPack packaging.
KOLANICH Jul 22, 2021
803f2e8
Added generation of a metadata file for pkg-config
KOLANICH Jul 22, 2021
a923d46
Moved inclusion of GNUInstallDirs closer to top. We would need the va…
KOLANICH Jul 22, 2021
a49cfa8
Fixed mistakes in CMake config file destinations. They are placed int…
KOLANICH Jul 22, 2021
856df8b
Eliminated repipitions of CMake config file for Lyra (that were the s…
KOLANICH Jul 22, 2021
4d72c62
Changed the incorrect path to CMake config for Lyra. These files are …
KOLANICH Jul 22, 2021
8c3098b
The library is header-only, it is architecture-insdependent. So pkg-c…
KOLANICH Jul 22, 2021
3d69d37
Fixed the path to includes. It should not be hardcoded, rather it sho…
KOLANICH Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 36 additions & 10 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,30 @@

# Only need the basic minimum of project, add_library, and
# target_include_directories commands.
cmake_minimum_required( VERSION 3.0 )
cmake_minimum_required( VERSION 3.12 )

# Don't set VERSION, as that's a pita to keep up to date with the version
# header. And don't set LANGUAGES as we are multi-language and header
# only, so it's irrelevant.
project( lyra )
project( lyra
VERSION "1.6"
DESCRIPTION "A simple to use, composing, header only, command line arguments parser for C++ 11 and beyond."
HOMEPAGE_URL "https://github.com/bfgroup/Lyra"
)
set(CPACK_PACKAGE_NAME "${PROJECT_NAME}")
set(CPACK_PACKAGE_VERSION "${PROJECT_VERSION}")
set(CPACK_PACKAGE_VENDOR "${PROJECT_NAME} developers")
set(CPACK_PACKAGE_DESCRIPTION "${PROJECT_DESCRIPTION}")
set(CPACK_DEBIAN_PACKAGE_NAME "lib${CPACK_PACKAGE_NAME}-dev")
set(CPACK_RPM_PACKAGE_NAME "lib${CPACK_PACKAGE_NAME}-devel")
Copy link

@jbadwaik jbadwaik Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the CPack command won't fail because it will try to generate packages for every single distribution listed here? May be make sure that the cpack won't fail on different platforms.

This is something you can write a test for on each platform in the CI. The CI should generate cpack packages and succeed in doing so.

set(CPACK_PACKAGE_HOMEPAGE_URL "${PROJECT_HOMEPAGE_URL}")
set(CPACK_PACKAGE_MAINTAINER "${CPACK_PACKAGE_VENDOR}")
set(CPACK_DEBIAN_PACKAGE_MAINTAINER "${CPACK_PACKAGE_MAINTAINER}")
set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE.txt")
set(CPACK_RESOURCE_FILE_README "${CMAKE_CURRENT_SOURCE_DIR}/README.adoc")

include(GNUInstallDirs)
string(REPLACE "/${CMAKE_LIBRARY_ARCHITECTURE}" "" INSTALL_LIBDIR_ARCHIND "${CMAKE_INSTALL_LIBDIR}")

# Simple INTERFACE, and header only, library target.
add_library( lyra INTERFACE )
Expand All @@ -35,20 +53,21 @@ target_include_directories(
lyra
INTERFACE
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)

# Add an alias to public name.
add_library( bfg::lyra ALIAS lyra )

## Installation Code
include(GNUInstallDirs)
set(LYRA_INSTALL_CONFIGDIR "${INSTALL_LIBDIR_ARCHIND}/cmake/lyra")
set(PkgConfigTemplatesDir "${CMAKE_CURRENT_SOURCE_DIR}/data/pkgconfig")

## Installation Code
include(CMakePackageConfigHelpers)
configure_package_config_file(
${PROJECT_SOURCE_DIR}/data/cmake/lyraConfig.cmake.in
${PROJECT_BINARY_DIR}/lyraConfig.cmake
INSTALL_DESTINATION ${CMAKE_INSTALL_DATADIR}/lyra
INSTALL_DESTINATION "${LYRA_INSTALL_CONFIGDIR}"
)

install(
Expand All @@ -60,19 +79,26 @@ install(
EXPORT lyraTarget
FILE lyraTarget.cmake
NAMESPACE bfg::
DESTINATION ${CMAKE_INSTALL_DATADIR}/lyra/cmake
DESTINATION "${LYRA_INSTALL_CONFIGDIR}"
)

install(
DIRECTORY ${PROJECT_SOURCE_DIR}/include
DESTINATION ${CMAKE_INSTALL_PREFIX}
DIRECTORY ${PROJECT_SOURCE_DIR}/include/lyra
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
)

install(
FILES
${PROJECT_BINARY_DIR}/lyraConfig.cmake
DESTINATION ${CMAKE_INSTALL_DATADIR}/lyra/cmake/
DESTINATION "${LYRA_INSTALL_CONFIGDIR}"
)

set(PKG_CONFIG_FILE_NAME "${PROJECT_BINARY_DIR}/${PROJECT_NAME}.pc")
configure_file("${PkgConfigTemplatesDir}/pkgconfig.pc.in" "${PKG_CONFIG_FILE_NAME}" @ONLY)
install(FILES "${PKG_CONFIG_FILE_NAME}"
DESTINATION "${INSTALL_LIBDIR_ARCHIND}/pkgconfig"
)

include(CPack)


7 changes: 7 additions & 0 deletions data/pkgconfig/pkgconfig.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
prefix=@CMAKE_INSTALL_PREFIX@
includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@

Name: @PROJECT_NAME@
Description: @PROJECT_DESCRIPTION@
Version: @PROJECT_VERSION@
Cflags: -I${includedir}