Skip to content

Fix DespawnOn not upholding invariants on entities with default filters #21616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

Fix DespawnOn not upholding invariants on entities with default filters #21616

merged 1 commit into from
Oct 20, 2025
+6 −2

Conversation

janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Oct 20, 2025 •
edited
Loading

Objective

Solution

Testing

  • None. I think this is trivial enough.

@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2025
@janhohenheim janhohenheim requested a review from chescock October 20, 2025 18:12
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-ECS Entities, components, systems, and events A-States App-level states machines X-Contentious There are nontrivial implications that should be thought through and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 20, 2025
@alice-i-cecile
Copy link
Member

I think that despawning disabled entities here is correct: it's too easy to end up with a serious bug or memory leak otherwise.

@janhohenheim janhohenheim added this to the 0.18 milestone Oct 20, 2025
AlephCubed
AlephCubed approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@AlephCubed AlephCubed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixes #20167 :)

@janhohenheim
Copy link
Member Author

Good catch, thanks!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2025
Merged via the queue into bevyengine:main with commit 6c56e2f Oct 20, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@chescock chescock chescock approved these changes

@AlephCubed AlephCubed AlephCubed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events A-States App-level states machines C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

DespawnOnEnter/DespawnOnExit no longer working on Observers DespawnOnExitState ignores disabled entities.

4 participants

@janhohenheim @alice-i-cecile @chescock @AlephCubed