Remove ron
re-export from bevy_scene
and bevy_asset
#21611
Merged
+15
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
As discussed in #19285, Bevy has reused the same conceptual names for multiple types across different crates, creating confusion for autocomplete tooling and users. This PR addresses one of those conflicts by removing the
ron
re-export frombevy_scene
andbevy_asset
Solution
pub use bevy_asset::ron;
frombevy_scene::lib
andpub use ron;
frombevy_asset::lib
crates/bevy_scene/Cargo.toml
ron
directly:crates/bevy_scene/src/dynamic_scene.rs
crates/bevy_scene/src/scene_loader.rs
crates/bevy_scene/src/serde.rs
(including doc examples and tests)Testing
cargo check --workspace
- all checks passcargo test -p bevy_scene
- tests pass (4 pre-existing test failures unrelated to this change)cargo test -p bevy_asset
- tests passcargo clippy
- no new warnings