Skip to content

Conversation

WaterWhisperer
Copy link
Contributor

@WaterWhisperer WaterWhisperer commented Oct 20, 2025

Objective

As discussed in #19285, Bevy has reused the same conceptual names for multiple types across different crates, creating confusion for autocomplete tooling and users. This PR addresses one of those conflicts by removing the ron re-export from bevy_scene and bevy_asset

Solution

  • Removed pub use bevy_asset::ron; from bevy_scene::lib and pub use ron; from bevy_asset::lib
  • Updated crates/bevy_scene/Cargo.toml
  • Updated all internal references to use ron directly:
    • crates/bevy_scene/src/dynamic_scene.rs
    • crates/bevy_scene/src/scene_loader.rs
    • crates/bevy_scene/src/serde.rs (including doc examples and tests)

Testing

  • cargo check --workspace - all checks pass
  • cargo test -p bevy_scene - tests pass (4 pre-existing test failures unrelated to this change)
  • cargo test -p bevy_asset - tests pass
  • cargo clippy - no new warnings

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Scenes Serialized ECS data stored on the disk X-Contentious There are nontrivial implications that should be thought through labels Oct 20, 2025
@alice-i-cecile alice-i-cecile added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Oct 20, 2025
@WaterWhisperer WaterWhisperer force-pushed the remove branch 2 times, most recently from 2d830ee to f53858b Compare October 21, 2025 01:14
@WaterWhisperer WaterWhisperer changed the title Remove ron re-export from bevy_scene Remove ron re-export from bevy_scene and bevy_asset Oct 21, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 21, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 21, 2025
Merged via the queue into bevyengine:main with commit 3dd5d70 Oct 21, 2025
42 checks passed
@WaterWhisperer WaterWhisperer deleted the remove branch October 21, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Scenes Serialized ECS data stored on the disk C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants