Skip to content

Delete System::component_access(). #19496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delete System::component_access(). #19496

wants to merge 2 commits into from
+24 −59

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • Delete System::component_access(). It is redundant with System::component_access_set().combined_access().

Testing

  • None. There are no callers of this function.

@andriyDev andriyDev added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 5, 2025
@andriyDev andriyDev force-pushed the no-component-access branch from 0c963ef to 43ede95 Compare June 5, 2025 02:19
chescock
chescock approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@chescock chescock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this technically needs a migration guide, since external code could be calling System::component_access().

The duplication here is my fault. I added component_access_set as a new method in #16885 rather than changing the old one in order to make that PR a little smaller by not having to update existing callers. Thanks for fixing it!

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chescock chescock chescock approved these changes

@Trashtalk217 Trashtalk217 Trashtalk217 approved these changes

@re0312 re0312 re0312 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andriyDev @chescock @Trashtalk217 @re0312