Skip to content

Update mfg ID (FLMO -> STBE) #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update mfg ID (FLMO -> STBE) #877

wants to merge 1 commit into from
+1 −1

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated manufacturer identifier to STBE. This change updates branding across visible areas such as About screens, device info panels, firmware details, and diagnostic logs.
    • No functional impact expected; behavior and configurations remain unchanged. Third-party tools or integrations that display the manufacturer name may show the updated identifier.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025 •
edited
Loading

Walkthrough

Updated the MANUFACTURER_ID macro in configs/GRAVITYF7/config.h from FLMO to STBE.

Changes

Cohort / File(s) Summary of Changes
Config constant update
configs/GRAVITYF7/config.h		 Updated macro definition: MANUFACTURER_ID changed from FLMO to STBE.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc5308b and dfdbd77.

📒 Files selected for processing (1)
  • configs/GRAVITYF7/config.h (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings 
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
📚 Learning: 2025-07-14T15:47:16.394Z 
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.

Applied to files:

  • configs/GRAVITYF7/config.h
📚 Learning: 2025-07-03T15:17:30.040Z 
Learnt from: haslinghuis
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T15:17:30.040Z
Learning: In Betaflight configurations, when a target name suggests dual IMUs (like JHEF7DUAL) but specific hardware variants only have one gyro available, the preferred solution is to use DEFAULT_GYRO_TO_USE macro to specify which gyro to use by default rather than pruning gyro defines or creating redundant configurations. This approach maintains compatibility when the same target is used by multiple hardware variants from the same manufacturer.

Applied to files:

  • configs/GRAVITYF7/config.h
📚 Learning: 2025-07-03T04:33:57.480Z 
Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the `BOARD_NAME` define in config.h files exactly matches the directory name where the config file is located. For example, if the config file is in configs/AXISFLYINGF7AIO/config.h, then the BOARD_NAME should be defined as "AXISFLYINGF7AIO". This ensures proper board identification and configuration loading in Betaflight.

Applied to files:

  • configs/GRAVITYF7/config.h
📚 Learning: 2025-07-03T04:33:57.480Z 
Learnt from: ot0tot
PR: betaflight/config#0
File: :0-0
Timestamp: 2025-07-03T04:33:57.480Z
Learning: Always verify that the BOARD_NAME define in each config.h matches the directory name it resides in (e.g., configs/AXISFLYINGF7AIO/config.h must have #define BOARD_NAME AXISFLYINGF7AIO). This check is required for all Betaflight board configuration reviews.

Applied to files:

  • configs/GRAVITYF7/config.h
🔇 Additional comments (1)
configs/GRAVITYF7/config.h (1)

27-27: Approval: GRAVITYF7 config.h BOARD_NAME and MANUFACTURER_ID verified

All checks have passed:

  • configs/GRAVITYF7/config.h defines BOARD_NAME as GRAVITYF7, matching its directory name.
  • configs/GRAVITYF7/config.h defines MANUFACTURER_ID as STBE, a valid 4-character ASCII code.
  • No residual FLMO identifiers were found across all configs.
  • The new manufacturer ID STBE appears consistently in other Stellar targets, as expected.

LGTM—merging.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch haslinghuis-patch-8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@haslinghuis haslinghuis mentioned this pull request Aug 20, 2025
Closed
8 tasks
@haslinghuis haslinghuis changed the title Update mfg ID Update mfg ID (FLMO -> STBE) Aug 20, 2025
@ot0tot
Copy link
Contributor

ot0tot commented Aug 25, 2025

Isn't this Flymod?
https://flymod.net/en/item/flymod_gravity_f7

@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 25, 2025 •
edited
Loading

@ot0tot see betaflight/unified-targets@03349d2 but asked @cvetaevvitaliy for info

@cvetaevvitaliy
Copy link
Contributor

cvetaevvitaliy commented Aug 25, 2025 •
edited
Loading

Isn't this Flymod?

https://flymod.net/en/item/flymod_gravity_f7

Yes

gravity f7 - no longer manufactured and is archival.

gravity f7 - FLMO
stellar - STBE

@haslinghuis haslinghuis deleted the haslinghuis-patch-8 branch August 25, 2025 18:34
@haslinghuis
Copy link
Member Author

Continue in #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugaarK sugaarK sugaarK approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@ot0tot ot0tot Awaiting requested review from ot0tot

@nerdCopter nerdCopter Awaiting requested review from nerdCopter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @ot0tot @cvetaevvitaliy @sugaarK