feat(config): update and sort manufacturers list #874
Conversation
Adds new manufacturers from issue betaflight#873 and sorts the entire list alphabetically.
|
Warning Rate limit exceeded@haslinghuis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
see #873 (comment) -- will update |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (6)
Manufacturers.md (6)
24-25: BKRC/BLDY placement looks fine; clarify BKRC contact and note AI summary inconsistency.
- BKRC currently has an empty contact. If you have an official site or repo, please add it for consistency.
- The AI summary mentions duplicate reintroductions of BKRC/BLDY elsewhere, but in the final file they appear only here.
If you can provide a URL for BKRC, I can prep a patch.
51-51: Two IDs map to “Flash Hobby” (FHRC and FLHB) — confirm intent.Both rows point to the same brand and URL. If both IDs are truly used in the ecosystem, consider adding a short clarifier in Name (e.g., legacy vs. current) or confirm one isn’t redundant.
Also applies to: 56-56
59-59: FLMO has no contact URL — please add if available.Empty contact fields reduce usefulness of this directory.
128-128: SSAK has no contact URL — please add if available.
1-7: Bare URLs are consistent with this file’s convention; ensure markdownlint MD034 is waived.Per prior repo convention (learnings), this table intentionally uses bare URLs. If markdownlint runs in CI, MD034 should be disabled for this file or overridden globally to avoid false positives.
Would you like a small PR to add a file-level markdownlint disable directive or adjust the linter config?
6-7: Optional: Clean up and validate Manufacturers.mdSummary of script findings:
- No duplicate Manufacturer Ids.
- Empty contact fields for: CUST, FOSS, COMM, LEGA, BKRC, FLMO, SSAK, VWIN, YYRC.
- Malformed URL for NGUA (“httpshttps://ng.uavp.ch/Shop”).
- Rows are not sorted by Manufacturer Id.
Recommendations:
- Fill in or remove empty contact entries.
- Correct the NGUA link to
https://ng.uavp.ch/Shop.- Sort the table rows alphabetically by the first column (Manufacturer Id).
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(5 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: haslinghuis
PR: betaflight/config#863
File: Manufacturers.md:116-116
Timestamp: 2025-08-14T17:46:20.018Z
Learning: In Betaflight's Manufacturers.md file, all URLs are formatted as bare URLs without angle brackets. This is the consistent pattern used throughout the entire table with 92 bare URLs and 0 wrapped URLs.
📚 Learning: 2025-08-14T17:46:20.018Z
Learnt from: haslinghuis
PR: betaflight/config#863
File: Manufacturers.md:116-116
Timestamp: 2025-08-14T17:46:20.018Z
Learning: In Betaflight's Manufacturers.md file, all URLs are formatted as bare URLs without angle brackets. This is the consistent pattern used throughout the entire table with 92 bare URLs and 0 wrapped URLs.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
58-58: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
67-67: Bare URL used
(MD034, no-bare-urls)
85-85: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
126-126: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
130-130: Bare URL used
(MD034, no-bare-urls)
131-131: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (5)
Manufacturers.md (5)
47-47: Add EMAX entry — looks good.
67-67: Add GEEL (Geelang) — looks correct.
85-85: JMI points to JHEMCU — verify the ID/name per issue feedback.There’s already JHEF (JHE_FPV) for the same domain. You noted you’ll update “JMI” based on feedback; please confirm:
- Whether “JMI” is the intended manufacturer_id
- Whether Name should remain “JHEMCU,” or if this is a different entity
- That adding a second ID for the same brand is intentional
117-117: Add SDRC (Siangda Model) — looks correct.
131-131: Confirm manufacturer_id character policy for “SU25”.Most IDs are 4 uppercase letters. If non-letter characters are allowed, no action needed. If not, consider a 4-letter alternative for Sub250. Please confirm against configurator/loader expectations.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
Manufacturers.md (3)
24-25: Fill missing contact for BKRC; BLDY entry looks fine. Also, AI summary’s “duplicate BKRC/BLDY” claim doesn’t match this file.
- BKRC currently lacks a Contact URL. Please add an official page if available.
- BLDY’s entry/URL looks correct.
- Note: The AI summary mentions duplicate BKRC/BLDY entries, but only one of each exists in this file.
If you have a URL for BKRC, apply:
-|BKRC|BAYCK RC|| +|BKRC|BAYCK RC|https://<official-site>|
59-59: Missing Contact for FLMO.Consider adding an official URL for discoverability and consistency.
-|FLMO|FLMO|| +|FLMO|FLMO|https://<official-site>|
128-128: Missing Contact for SSAK.Please add an official URL if available.
-|SSAK|Dezhou Yingfei Intelligent Technology Co., Ltd|| +|SSAK|Dezhou Yingfei Intelligent Technology Co., Ltd|https://<official-site>|
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
58-58: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
67-67: Bare URL used
(MD034, no-bare-urls)
85-85: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
126-126: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
130-130: Bare URL used
(MD034, no-bare-urls)
131-131: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (6)
Manufacturers.md (6)
52-52: Confirm manufacturer_id “FISH” for SwellPro.“FISH” seems unrelated to the brand name “SwellPro”. Please confirm ID choice with maintainers or issue #873; consider a mnemonic closer to the brand if there isn’t historical precedent.
Would you like me to open a follow-up to align the ID with project conventions after confirmation?
67-67: GEEL (Geelang) addition — LGTM.Entry looks correct and ordering by manufacturer_id is preserved.
47-47: EMAX addition — LGTM.Correctly inserted in sorted order by manufacturer_id.
85-85: JMI appears to duplicate JHEMCU (same URL as JHEF). Please confirm intent.If JMI is an alias for the same vendor as JHEF/JHEMCU, a second manufacturer_id may be unnecessary and could cause confusion. If a new ID is required (per community consensus), document the distinction in the Name field.
Provisional removal until resolved:
-|JMI|JHEMCU|https://www.jhemcu.com/|If the ID needs to stay, consider a Name that distinguishes it from JHEF (e.g., specific product line or legal entity).
117-117: SDRC addition — LGTM.Looks valid and maintains sort order.
131-131: SU25 (Sub250) addition — LGTM.Entry and ordering look good.
|
@coderabbitai, you used the word |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 7829 @nerdCopter You're absolutely correct, and I apologize for the inaccuracy in my summary. After examining the actual file: BKRC and BLDY each appear only once in the file:
They are positioned alphabetically between The changes were indeed about sorting the manufacturers list alphabetically as intended, not about reintroducing or duplicating existing entries. Thank you for the correction! |
Co-authored-by: Mark Haslinghuis <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Manufacturers.md (1)
6-148: Automated Validation Failed – Fix Table Ordering in Manufacturers.mdYour validation script uncovered that the
Manufacturers.mdtable is not in strict ascending order by Manufacturer Id. Please correct the following rows:
- “COMM” at line 10 should appear before “FOSS” at line 9
- “AEDR” at line 12 should appear before “LEGA” at line 11
Once reordered, re-run the validation script to confirm that:
- Every Manufacturer Id is exactly 4 uppercase alphanumeric characters
- No duplicate Names or URLs exist
- The table is fully alphabetized by Id
- Config references align with the updated Id list
🧹 Nitpick comments (2)
Manufacturers.md (2)
58-58: FLMO is incomplete (missing Name/Contact).An entry with Name identical to the ID and no URL reduces catalog quality and can confuse downstream users. Either fill in the official name and contact, or temporarily drop the row until details are known.
Apply this minimal, reversible diff if you prefer to omit it for now:
-|FLMO|FLMO||
127-127: Consider adding a Contact URL for SSAK.Optional, but adding a URL improves discoverability and parity with adjacent entries. If no official site exists, leaving it blank is acceptable.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T15:47:16.394Z
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
59-59: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
83-83: Bare URL used
(MD034, no-bare-urls)
84-84: Bare URL used
(MD034, no-bare-urls)
116-116: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
126-126: Bare URL used
(MD034, no-bare-urls)
128-128: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
130-130: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (7)
Manufacturers.md (7)
24-25: BKRC/BLDY ordering looks correct.IDs remain 4 ASCII chars and the sort by Manufacturer Id is preserved here (BKRC before BLDY). No issues spotted.
47-47: EMAX entry added — OK.Canonical brand and URL look good; conforms to 4-char ID policy.
51-51: Confirm mapping: FISH → SwellPro.The ID “FISH” for “SwellPro” is non-obvious and could be confused with other brands. Please confirm this mapping is intentional and community-approved, otherwise consider a mnemonic 4-char ID aligned with the brand.
55-55: Canonicalized Flash Hobby under FLHB — looks good.Thanks for removing the ambiguity with the prior FHRC vs FLHB discussion and keeping FLHB as the canonical ID.
66-66: GEEL added — OK.Matches brand and URL; conforms to 4-char policy.
116-116: SDRC addition — OK.Looks consistent (name and URL present, 4-char ID).
130-130: SU25 (Sub250) addition — OK.Valid 4-char ID (digits allowed), proper URL.
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
Manufacturers.md (2)
58-58: FLMO has no contact URL — confirm this isn’t a placeholder.If FLMO represents an active manufacturer, consider adding a contact URL (consistent with the table’s pattern). If it’s a reserved/placeholder ID, consider omitting until needed to avoid ecosystem churn.
Would you like a quick check script to flag rows with empty Contact cells for follow-up?
126-126: SSAK has empty contact — optional improvement.If a public site exists, add it for consistency and discoverability. Otherwise, leaving blank is acceptable per current table conventions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T15:47:16.394Z
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
59-59: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
83-83: Bare URL used
(MD034, no-bare-urls)
115-115: Bare URL used
(MD034, no-bare-urls)
116-116: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
128-128: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (6)
Manufacturers.md (6)
24-25: BKRC/BLDY positions look correct and alphabetically ordered.No duplication here and the sort by Manufacturer Id is preserved.
47-47: EMAX entry: OK.4-character ID, uppercase, valid-looking URL, and correct sort position.
66-66: GEEL entry: OK.Meets 4-char ID rule and sorting; URL looks correct.
115-115: SDRC entry: OK.Valid 4-char ID, sorted correctly, URL present.
129-129: SU25 entry: OK.Valid 4-character ID (alphanumeric allowed per project convention), sorted correctly, URL present.
47-47: New/updated IDs comply with the 4-character rule.All newly added/modified manufacturer_ids are exactly 4 ASCII characters, aligning with the project’s requirement remembered from prior PRs.
Also applies to: 51-51, 55-55, 58-58, 66-66, 115-115, 129-129
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Manufacturers.md (1)
6-147: Manufacturers.md: Fix missing contacts and sort orderPlease address the following issues in Manufacturers.md (lines 6–147):
Missing contact URLs for the following IDs (all other rows include a link in column 4):
• BKRC (BAYCK RC)
• FLMO (FLMO)
• SSAK (Dezhou Yingfei Intelligent Technology Co., Ltd)
• VWIN (Huizhou Xinmumu Technology Co., Ltd)
• YYRC (JLDZ)Incorrect alphabetical ordering between adjacent rows:
• SwapFOSSandCOMMso thatCOMMcomes beforeFOSS.
• MoveLEGAbelow all “A…” IDs (e.g. afterAZZZif present—or at least afterAEDR).Once the contact information is filled in (or explicitly marked as “n/a” if appropriate) and the rows are reordered to strict ASCII sort by Manufacturer Id, rerun the validation script to confirm:
awk -F'|' '…' Manufacturers.md
♻️ Duplicate comments (2)
Manufacturers.md (2)
55-55: Flash Hobby canonicalized to FLHB — ensure legacy FHRC is fully removed.Good consolidation. Please double-check there are no remaining FHRC references elsewhere (configs, docs).
Use:
#!/bin/bash set -euo pipefail rg -n --hidden -S '\bFHRC\b' -g '!Manufacturers.md' || echo "No FHRC references found."
51-51: Update SwellPro Manufacturer ID to Avoid ConflictTheMANUFACTURER_ID “FISH” is already defined in
configs/FISHERMANF405/config.h:27, causing a collision. Please choose a new, unique 4-character ASCII ID for SwellPro and re-sort the entry inManufacturers.md.• configs/FISHERMANF405/config.h:27 —
#define MANUFACTURER_ID FISH
• Manufacturers.md:51 — current row uses|FISH|SwellPro|…|Proposed change:
-|FISH|SwellPro|https://swellpro.com/| +|SWPR|SwellPro|https://swellpro.com/|Ensure the new ID is not used elsewhere and update the table ordering accordingly.
🧹 Nitpick comments (3)
Manufacturers.md (3)
24-25: BKRC/BLDY ordering looks correct; consider adding BKRC contact URL.Alphabetical position by Manufacturer Id is good. If you have a public site for BAYCK RC, adding it would improve completeness and consistency with nearby rows that already include contacts.
58-58: FLMO lacks a descriptive Name/Contact.If FLMO is a placeholder brand, consider providing the public-facing name and a contact URL. Leaving both as ID-only may reduce usefulness of the table.
126-126: SSAK has no contact URL.Optional but recommended: add a website/contact to align with most rows and aid users.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T15:47:16.394Z
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
59-59: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
83-83: Bare URL used
(MD034, no-bare-urls)
115-115: Bare URL used
(MD034, no-bare-urls)
116-116: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
128-128: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
Manufacturers.md (4)
47-47: EMAX entry looks good.Valid 4-character ID, sorted correctly, and contact provided.
66-66: GEEL entry looks correct.Unique 4-char ID, proper sort position, and contact provided.
115-115: SDRC entry looks correct.Meets 4-char ID requirement and includes a contact URL.
129-129: SU25 entry looks correct.Valid 4-character alphanumeric ID, sorted correctly, with contact URL.
|
transferring ownership to @haslinghuis , modify at will 😹 |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
Manufacturers.md (2)
55-55: Minor naming consistency: “Co.,Limited” → “Co., Ltd”; also ensure FHRC is fully deprecated.Most entries use “Co., Ltd”. Consider aligning for consistency. Separately, since FLHB is canonical now, sweep for any legacy FHRC references in configs.
Suggested name tweak:
-|FLHB|Flash Hobby Technology Co.,Limited|https://flashhobby.com/| +|FLHB|Flash Hobby Technology Co., Ltd|https://flashhobby.com/|Sweep for FHRC:
#!/bin/bash rg -n --hidden -S '\bFHRC\b' -g '!Manufacturers.md' || echo "No FHRC references found."
51-51: Manufacturer ID Conflict – Action RequiredIt’s been confirmed that FISH is already in use by
configs/FISHERMANF405/config.h:27, so assigning it to SwellPro would collide with the existing target. Please update SwellPro’s entry to a new, unique 4-character ASCII ID (for example,SWPR), then re-run the global uniqueness and sort-order checks.• Locations to update:
Manufacturers.md(line 51)- Any SwellPro-specific board configs you’ve added that reference
MANUFACTURER_ID FISH• Example patch:
- |FISH|SwellPro|https://swellpro.com/| + |SWPR|SwellPro|https://swellpro.com/|• Next steps:
- Choose and apply a unique 4-char ID (e.g.
SWPR).- Re-sort
Manufacturers.mdto maintain ASCII ordering by ID.- Run the global grep check to ensure no duplicate IDs:
rg -n '^\|SWPR\|' Manufacturers.md rg -n 'MANUFACTURER_ID\s\+SWPR' configs/ rg -n 'MANUFACTURER_ID\s\+FISH' configs/ # confirm no unintended references- Verify all builds still pass with the new ID.
🧹 Nitpick comments (3)
Manufacturers.md (3)
24-25: BKRC/BLDY sorted correctly; consider adding BKRC contact URL.Ordering looks good. BKRC has an empty contact — add a URL when available to keep parity with neighboring entries. Also double-check the “BAYCK RC” spelling.
58-58: FLMO lacks a proper Name/Contact — confirm before merging.Using the ID as the Name and leaving Contact empty makes the row less useful. Please provide the official company/brand name and a URL, or defer adding this row until details are confirmed.
126-126: SSAK missing contact — optional improvement.If a website is available, add it to help users identify the vendor.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T15:47:16.394Z
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
57-57: Bare URL used
(MD034, no-bare-urls)
59-59: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
66-66: Bare URL used
(MD034, no-bare-urls)
83-83: Bare URL used
(MD034, no-bare-urls)
115-115: Bare URL used
(MD034, no-bare-urls)
116-116: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
125-125: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
128-128: Bare URL used
(MD034, no-bare-urls)
129-129: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (5)
Manufacturers.md (5)
66-66: GEEL entry looks good.
83-83: JHEF correction to “Shenzhen Jinhang Electronic Co., Ltd” — LGTM.This aligns with earlier discussions and resolves the prior typo/duplication concerns.
115-115: SDRC addition — LGTM.ID format and placement are correct; URL provided.
129-129: SU25 (Sub250) — LGTM.4-char ASCII ID with digits is acceptable; order is correct.
47-47: Confirmed: EMAX manufacturer ID is unique and consistentI’ve verified that EMAX appears only in the four EMAX-branded configs and nowhere else, and the entry in Manufacturers.md matches their 4-character ID exactly:
- configs/EMAX_TINYHAWK_F411RX/config.h
- configs/EMAX_TINYHAWKF4SX1280/config.h
- configs/EMAX_BABYHAWK_II_HD/config.h
- configs/EMAX_F405_ELRS_AIO/config.h
No other targets use or conflict with EMAX. The addition to Manufacturers.md is correct.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Manufacturers.md (1)
6-146: Fix alphabetical sort of Manufacturer IDsThe sanity-check script confirms there are no ID format violations or duplicates, but it uncovered two ordering issues in
Manufacturers.md:• “FOSS” appears after “COMM” – it should precede it.
• “LEGA” appears before “AEDR” – it should follow it.Please reorder those rows so that all 4-char IDs appear in strict ascending order. After making the swaps, rerun the provided script to ensure “Order OK” is reported.
♻️ Duplicate comments (1)
Manufacturers.md (1)
54-54: Flash Hobby canonicalized to FLHB — LGTMThanks for eliminating FHRC/FHRC ambiguity. The follow-up deprecation in PR #875 addresses downstream references.
🧹 Nitpick comments (1)
Manufacturers.md (1)
125-125: SSAK contact omitted — add if availableIf an official website exists, add it for completeness; otherwise leaving blank is acceptable per current table conventions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Manufacturers.md(4 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T15:47:16.394Z
Learnt from: ot0tot
PR: betaflight/config#681
File: configs/NYX405V1/config.h:26-28
Timestamp: 2025-07-14T15:47:16.394Z
Learning: In Betaflight configuration files, MANUFACTURER_ID values must be exactly 4 ASCII characters long, not 3 characters. All manufacturer IDs in the codebase consistently use 4-character identifiers like AIRB, FOSS, SPBE, MTKS, NERC, etc.
Applied to files:
Manufacturers.md
🪛 markdownlint-cli2 (0.17.2)
Manufacturers.md
25-25: Bare URL used
(MD034, no-bare-urls)
47-47: Bare URL used
(MD034, no-bare-urls)
48-48: Bare URL used
(MD034, no-bare-urls)
49-49: Bare URL used
(MD034, no-bare-urls)
50-50: Bare URL used
(MD034, no-bare-urls)
51-51: Bare URL used
(MD034, no-bare-urls)
52-52: Bare URL used
(MD034, no-bare-urls)
53-53: Bare URL used
(MD034, no-bare-urls)
54-54: Bare URL used
(MD034, no-bare-urls)
55-55: Bare URL used
(MD034, no-bare-urls)
56-56: Bare URL used
(MD034, no-bare-urls)
58-58: Bare URL used
(MD034, no-bare-urls)
59-59: Bare URL used
(MD034, no-bare-urls)
60-60: Bare URL used
(MD034, no-bare-urls)
61-61: Bare URL used
(MD034, no-bare-urls)
62-62: Bare URL used
(MD034, no-bare-urls)
63-63: Bare URL used
(MD034, no-bare-urls)
64-64: Bare URL used
(MD034, no-bare-urls)
65-65: Bare URL used
(MD034, no-bare-urls)
82-82: Bare URL used
(MD034, no-bare-urls)
114-114: Bare URL used
(MD034, no-bare-urls)
115-115: Bare URL used
(MD034, no-bare-urls)
116-116: Bare URL used
(MD034, no-bare-urls)
117-117: Bare URL used
(MD034, no-bare-urls)
118-118: Bare URL used
(MD034, no-bare-urls)
119-119: Bare URL used
(MD034, no-bare-urls)
120-120: Bare URL used
(MD034, no-bare-urls)
121-121: Bare URL used
(MD034, no-bare-urls)
122-122: Bare URL used
(MD034, no-bare-urls)
123-123: Bare URL used
(MD034, no-bare-urls)
124-124: Bare URL used
(MD034, no-bare-urls)
126-126: Bare URL used
(MD034, no-bare-urls)
127-127: Bare URL used
(MD034, no-bare-urls)
128-128: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (6)
Manufacturers.md (6)
24-25: BKRC/BLDY positions look correct and alphabetically orderedEntries are singletons and correctly sorted within the B* block. No action needed.
57-57: FLMO entry lacks details — confirm placeholder vs. complete infoCurrently “Name=FLMO” and no contact. If FLMO is an acronym, consider expanding the full company/brand name and adding a URL; otherwise confirm this is intentionally minimal.
65-65: GEEL (Geelang) entry — LGTMID format, name, and URL look consistent with the table’s conventions.
82-82: JHEF rename to “Shenzhen Jinhang Electronic Co., Ltd” — LGTMSpelling and URL look correct; 4-char ID rule satisfied. Acknowledging the JMI follow-up will be handled separately as discussed.
114-114: SDRC (Siangda Model Co., Ltd) — verify official siteEntry reads well; please confirm https://www.sdmodel.com.tw/ is the official manufacturer site for this ID.
47-47: Confirm EMAX canonical URL – emaxmodel.com is correctBased on the official support information, EMAX USA (emax-usa.com) serves only United States and Canada, while EMAX Model (emaxmodel.com) provides international sales and support for all other regions (emax-usa.com). A ripgrep search in
configs/shows only the manufacturer IDEMAX(noEMAXUSAentries), so we don’t need a separateEMAXUSAentry (emax-usa.com). The existing entry|EMAX|EMAX|https://emaxmodel.com/|is therefore correct and requires no changes.
|
@ot0tot should be ready - we need more data for JMI |
Summary by CodeRabbit