Skip to content

Fix intermittent invalid state error in loadfile (cli) #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Fix intermittent invalid state error in loadfile (cli) #4642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b110ff3
Fix intermittent invalid state error in loadfile (cli)
haslinghuis Sep 30, 2025
5b3b79c
Found the rootcause
haslinghuis Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/js/tabs/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ cli.initialize = function (callback) {
self.cliBuffer = "";
self.startProcessing = false;

// Reset modal dialog reference since DOM gets rebuilt on tab switch
self.GUI.snippetPreviewWindow = null;

const enterKeyCode = 13;

function clearHistory() {
Expand Down Expand Up @@ -159,6 +162,7 @@ cli.initialize = function (callback) {
);
$("#snippetpreviewcontent a.confirm").click(() => executeSnippet(fileName));
}

previewArea.val(result);
self.GUI.snippetPreviewWindow.showModal();
}
Expand Down
14 changes: 9 additions & 5 deletions src/js/utils/initializeModalDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,15 @@ export function initializeModalDialog(activationSelector, dialogSelector, messag
onClose && onClose();
});
// Handle activation button click
$(activationSelector).on("click", () => {
dialogElement.showModal();
// Reset any previous scrolling
dialogContainerElement.scroll(0, 0);
});
if (activationSelector) {
$(activationSelector).on("click", () => {
dialogElement.showModal();
// Reset any previous scrolling
if (dialogContainerElement) {
dialogContainerElement.scroll(0, 0);
}
});
}
// Return dialog element
return dialogElement;
}