Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

3 fixes #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

3 fixes #51

wants to merge 4 commits into from

Conversation

payflix
Copy link

@payflix payflix commented Jan 23, 2018

  • Added better textTrackStyles using Netflix and Google documentation
  • Fixed "video.js:489 VIDEOJS: WARN: videojs.createEl() is deprecated; use videojs.dom.createEl() instead"
  • Fixed "Active trackId before casting"

@payflix
// Set active track by selected subtitle
cb03e6c 
Missing activeTrackIds ?

After this update subtitles were displayed on the tv
@payflix
Merge pull request #1 from payflix/activetrackids-fix
744ad06 
 Set active track by selected subtitle
@payflix
Update videojs-chromecast.js
13626e1
@payflix
Update videojs-chromecast.js
0fe35bd
@DoomTay DoomTay mentioned this pull request May 18, 2018
Open
@DoomTay
Copy link

DoomTay commented May 18, 2018

I gave this a whirl and every time I try to cast something with it, I get an "invalid params" error

@areeb111
Copy link

areeb111 commented Oct 13, 2018 •
edited
Loading

@payflix
I have the same problem that the closed captions cannot be displayed on the Chromecast Receiver.
I have tried to apply your pull request for the Missing activeTrackIds,
But i got the following error in console.log:

VIDEOJS: Cast Error: {"code":"session_error","description":"INVALID_PARAMS","details":{"type":"INVALID_REQUEST","reason":"INVALID_PARAMS"}}

Can you help me out ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@payflix @DoomTay @areeb111