Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Fix the metadata and appId options assignments #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexgerv
Copy link

Currently, the appId is not being set correctly and was always defaulting to the default ID because the option was undefined.
The metadata was also affected by the same issue, and was fixed by PR #30

The proposed fix is to populate the options before calling super. Let me know what you think.

@drexseoj
Copy link

We like to vote for this issue. as we can not use our own receiver unless we modify the module.

@alexgerv
Copy link
Author

@benjipott any comment on the PR ? Would you have another approach ?

@Fenny
Copy link
Contributor

Fenny commented Jan 23, 2018

@benjipott hello?

@DoomTay
Copy link

DoomTay commented May 16, 2018

Curiously, when I tried running this on a local HTML file or from a local server or even CodePen, the Chromecast button wouldn't show up, though it works just fine when running off a userscript.

Looking at it further, it seems the cause is that something about populating the options before calling super causes the receiverListener to fire only once.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants