[WIP] cleanup config #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… makes it so that this benchmark truly does not do anything
- MySQL use 5.7 by default, 8.0 fails - PostgreSQL use 10.1 by default
- some PR are pending for review, i.e. SQLServer, Cassandra - most new databases only support tpcc, ycsb, tpch (due to extra credit?)
- add util function to use bash and mysql for a running container, create database is also supported for tpcc - FIXME: tpcc config is using docker's mysql user and password config instead of the common `root` and empty password - TODO: might switch to python to avoid the inevitable copy paste in Makefile when adding multiple databases and benchmarks
- no actual test running, just print version, run and stop docker compose
- travis won't combine environment variables to build a matrix, one env item is one cell
- `if ['$DB' == 'MYSQL']` need the quote around `$DB` ....
- follow travis-ci/travis-ci#879 to see it will work ....
- it seems service are not enabled by default, but why docker-compose got problem when bind the port to host .... sudo ? ...
- found https://github.com/rijalati/docker-oltpbench, which matches the issue to solve perfectly, wonder why they didn't consider contribute it to upstream - parse args in `gen_config.py`
- based on https://github.com/cmu-db/peloton/blob/master/script/oltpbenchmark/benchmark.py - read template from `benchmarks/sample_{bench}_config.xml` - update database connection using data from `database.yml`
- amazing, it is not in travis default image ...
- by default it is installed for python2.7 ...
- [ ] postgres is using `postgresql` in jdbc connection - [ ] having trouble writing shell script to create database, so just hard coded to tpcc for now ... - edit `oltpbenchmark` so it switch to script's folder when running
- postgres is using `postgresql` in jdbc connection string - use `set -e` to make oltpbenchmark script return non zero code when exit - which is why previous postgres bench failed but travis passed ...
- the `--create` flag only create tables, database is written in jdbc connection string, if it is not created, benchmark would fail, this need to be automated ... - [ ] not sure about travis python version, need 3.6 to use newer subprocess higher level API https://docs.python.org/3/library/subprocess.html
- read from `databases.yml` to get db shell template
- some of them hard coded server ip ....
- said it can be deleted ...
- scan the package and find class that extends BenchModule needs external libraries, and the package management is a mess now ... - https://stackoverflow.com/questions/520328/can-you-find-all-classes-in-a-package-using-reflection - `Benchmarks.java` would register all the workloads in a hashmap
- using default YCSB config, cassandra would fail, it seems error are not handled on client end, also the jdbc wrapper for cassandra seems pretty buggy ... a lot of log only has `%s`, same statement is prepared everytime instead of reused .... - give it a shot on travis, might fail as well ... ```` Caused by: com.datastax.driver.core.exceptions.ReadFailureException: Cassandra failure during read query at consistency ONE (1 responses were required but only 0 replica responded, 1 failed) ````
- the code for dealing with alias is copied, it might be a better idea to share them using another file ... - update travis to run more tests
- previously the command for create database is executed inside container, however, tidb does not ship with mysql shell in image - [ ] FIXME: it seems TiDB does not accept the jdbc driver used by TiDB
- wonder where did things go wrong, isn't it mysql compatiable ...
- need to update the ddl, just copy mysql's, otherwise the default will be used - add new entry in `DatabaseType.java` - change log level for api to debug, otherwise won't know there is null due to DatabaseType not registered
- add MemSQL, but during the benchmark there are ton of exceptions ... might due to `REFERENCES` is not supported by MemSQL, I commented it out in the dialect - add more databases in travis - scalefactor is set 1 on travis, I guess that's why old travis for auction is passing, this should also slove cassandra ...
- stop travis's mysql and postgres regardless of $DB since there are many MySQL and PostgreSQL compatiable databases like MemSQL ...
|
closed in favor of #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up configuration, it is an issue from upstream oltpbenchmark#209 , we have to figure out those config anyway, also we can still use our own fork even if it is not accepted by upstream.
New Features
Clean up
runfolderUnclear stuff
Broken https://travis-ci.org/benchhub/oltpbench
config/traces/twitter_tweetids.txthttps://travis-ci.org/benchhub/oltpbench/jobs/332562406seatsbenchmarkconfig.plugin.xmlis still used, need to updateDBWorkloadclassLegacy issues that already fixed but not closed
Ref