Build: add dependency groups for tox/pyproject to simplify dev, docs,…

[farhannadim311]

This PR introduces PEP 735 dependency groups (dev, docs, pre-commit, towncrier) to both pyproject.toml and tox.ini.

This ensures contributors can reproduce the exact development, testing, and docs environments with consistent tooling. It replaces ad-hoc dependency lists and centralizes them for clarity. I made sure, the styling of the files stay the same

Solves inconsistencies in developer environments and makes tox easier to run by mapping environments directly to dependency groups.

If merged, contributors can run:

• pip install .[dev] → dev/test tools
• pip install .[docs] → docs build
• tox -e pre-commit → linting hooks
• tox -e towncrier-check → changelog check

Refs #3634

PR Checklist:

• All new features have been tested
• All new features have been documented
• I have read the CONTRIBUTING.md file
• I will abide by the code of conduct

[farhannadim311]

I would love feedback on this, as I want to merge my code, I did no styling changes and as for the ios test case failing, it managed to install all the dependencies, so it doesn't seem like a dependency related issue, however let me know what you guys think. i am willing to change any documentation if needed although i might need some guidance for that

[freakboy3742]

This is headed in the right direction; a couple of comments inline about some of the specifics.

However, the biggest question I have is why there haven't been any changes to the existing definitions of optional groups. This PR adds dependency groups - but doesn't remove the existing definitions. Even the PR description says:

If merged, contributors can run:

pip install .[dev] → dev/test tools
pip install .[docs] → docs build
...

which... isn't using dependency groups at all, and in my testing at least, doesn't work as described.

[freakboy3742]

Towncrier is a single word:

Suggested change

	"town-crier" = [
	"towncrier" = [

[freakboy3742]

We don't need to document what dependency groups are.

Suggested change

	# -------------------------------------------------------------------
	# PEP 735 dependency groups (root): used by tox & contributors.
	# These do NOT ship in built wheels.
	# -------------------------------------------------------------------

[freakboy3742]

Is there a reason these have been changed to editable installs?

[freakboy3742]

Again - is there a reason these have been switched to editable installs?

Also - it's not clear to me how/why this will be installing the dev dependencies for core. The [dev] group usage has been removed, but no equivalent dependency group has been added.

[freakboy3742]

Again - why editable installs?

[freakboy3742]

It seems a little weird that Pillow is defined twice. We probably want to define a optional group that includes Pillow, and then include optional as a sub-dependency of docs and dev.

[freakboy3742]

Also - the iOS test failure isn't anything you've done - the iOS simulator sometimes has a bad day for no particular reason. I've kicked off a re-run of that test.

[johnzhou721]

Hmm... I found out that #3719 already included this work... just pointing that out as my 2 cents. I don't know which will take priority though -- in my own opinion it'd depend on the timeframe of it getting merged, but I'm unfamiliar with the new MkDocs stuff.

[freakboy3742]

Hmm... I found out that #3719 already included this work... just pointing that out as my 2 cents. I don't know which will take priority though -- in my own opinion it'd depend on the timeframe of it getting merged, but I'm unfamiliar with the new MkDocs stuff.

The one that takes priority is the one that is finished first. In this case, there's a number of outstanding review items on this PR.

[freakboy3742]

Thanks for the contribution here; however, as noted in the comments, this has now been resolved indirectly by #3719.