Skip to content

Conversation

Odzen
Copy link

@Odzen Odzen commented Jul 19, 2025

This PR refactors the "Success Stories" page, converting the list of projects into a table to make the information more consistent and scannable.
The new table includes columns for screenshots, platforms, and BeeWare components, providing a clearer and more informative overview of what can be built with Toga.
Fixes #3596

PR Checklist:
[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is definitely a step in the right direction. However, I'm not convinced the screenshots work at this size. I found myself wanting to click on the image to get more detail - and that clearly doesn't do anything.

My thought: Drop the current "screenshot" column; add a small (32x32?) icon to the name column where we have a clear icon (e.g., the icon from App Store registrations), and replace the "components" column with a new "screenshots" column that, instead of being a thumbnail, is a list of hyperlinks to an images (the tanapro apps, for example, provide multiple screenshots, demonstrating that they work on different platforms; the same is true of Travel Tips, which has iOS, iPad and Android screenshots.

Comment on lines 18 to 20
- iOS
- Toga
- An app in the iOS App Store that describes its user interface.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- iOS
- Toga
- An app in the iOS App Store that describes its user interface.
- Android, iOS,
- Briefcase, Toga
- A currency conversion tool that can also calculate tips.

- Components
- Description

* - .. image:: https://is1-ssl.mzstatic.com/image/thumb/Purple116/v4/3e/72/15/3e72159d-ddbc-c34d-b8ad-e96abd34de6a/pr_source.png/626x0w.webp%20626w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL this image is being served from is... interesting. It looks like it might be a proxy for a Czech Apple app store... but it's definitely not a domain that I recognize

Also, if we're going to be serving images, we should be serving them from our own infrastructure - if only to prevent against the remove server disappearing the image.

:width: 32px
:height: 32px

.. _iPad: ../images/success_stories/travel_tips/travel_tips_ipad_screenshot.webp
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freakboy3742

Can you please guide me on how to add hyperlinks to the server using RST?
When I try to use a path like this /images/success_stories/travel_tips/travel_tips_ipad_screenshot.webp
It returns "Not Found".

Copy link
Member

@HalfWhitt HalfWhitt Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way I've been able to find to link to a static file is the :download: text role, but it's not exactly ideal... At least for me, in Firefox, clicking on this link both opens the image in a new tab and downloads a copy to my downloads folder:

:download:`iPad </images/success_stories/travel_tips/travel_tips_ipad_screenshot.webp>`

It seems like there should be a better way, but I don't know what it is.

Also, I wouldn't use relative links for all those icons. They'll break if this page ever, for whatever reason, gets moved one directory lower. Sphinx considers absolute file paths to start at the document root (toga/docs); /images/... should always be the images folder directly under docs.

@Odzen
Copy link
Author

Odzen commented Jul 19, 2025

Thanks for the PR. This is definitely a step in the right direction. However, I'm not convinced the screenshots work at this size. I found myself wanting to click on the image to get more detail - and that clearly doesn't do anything.

My thought: Drop the current "screenshot" column; add a small (32x32?) icon to the name column where we have a clear icon (e.g., the icon from App Store registrations), and replace the "components" column with a new "screenshots" column that, instead of being a thumbnail, is a list of hyperlinks to an images (the tanapro apps, for example, provide multiple screenshots, demonstrating that they work on different platforms; the same is true of Travel Tips, which has iOS, iPad and Android screenshots.

Thank you for the suggestions. I tried to implement some of them. I still have the hyperlink part for the screenshots missing.

@Odzen Odzen requested a review from freakboy3742 July 19, 2025 23:55
Success Stories
===============

Want to see examples of Toga in use? Here's some:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're sprucing this up, we might as well fix the subject-verb agreement: "Here are some:"

@HalfWhitt HalfWhitt changed the title fix format Reformat Success Stories Jul 20, 2025
@freakboy3742
Copy link
Member

One option: it's possible to do a lightbox popup in pure CSS. We might need to do a little work to clean up the styling in that example, and to template it in a way so we can add screenshots easily - but it would be a nicer option than popping out to a separate page.

@Odzen
Copy link
Author

Odzen commented Aug 2, 2025

I will have a look at this next weekend, thank you for the patiente here @freakboy3742 , @HalfWhitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Success stories improvements

3 participants