Skip to content

Provide option to invoke callbacks within Scope.$apply #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide option to invoke callbacks within Scope.$apply #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33bed92
Provide option to invoke callbacks within Scope.$apply
itzg Dec 21, 2016
317d50a
Fix lint issues
itzg Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/ng-stomp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,16 @@ angular
this.sock = null
this.stomp = null
this.debug = null
this.scopedApply = false

this.setDebug = function (callback) {
this.debug = callback
}

this.setScopedApply = function (apply) {
this.scopedApply = apply
}

this.connect = function (endpoint, headers, errorCallback) {
headers = headers || {}

Expand All @@ -30,12 +35,19 @@ angular
this.sock = new SockJS(endpoint)
this.stomp = Stomp.over(this.sock)
this.stomp.debug = this.debug
var us = this
this.stomp.connect(headers, function (frame) {
dfd.resolve(frame)
}, function (err) {
dfd.reject(err)
if (angular.isFunction(errorCallback)) {
errorCallback(err);
if (us.scopedApply) {
$rootScope.$apply(function () {
errorCallback(err)
})
} else {
errorCallback(err)
}
}
})

Expand All @@ -50,13 +62,20 @@ angular

this.subscribe = this.on = function (destination, callback, headers) {
headers = headers || {}
var us = this
return this.stomp.subscribe(destination, function (res) {
var payload = null
try {
payload = JSON.parse(res.body)
} finally {
if (callback) {
callback(payload, res.headers, res)
if (angular.isFunction(callback)) {
if (us.scopedApply) {
$rootScope.$apply(function () {
callback(payload, res.headers, res)
})
} else {
callback(payload, res.headers, res)
}
}
}
}, headers)
Expand Down