Skip to content

fix: solar span too tight #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: fix-solar-differences
Choose a base branch
from

Conversation

simon-something
Copy link
Contributor

fix the span used when parsing with solar (which currently is either the item span if the doc comment is missing, or only the doc comment if it does exist)

Copy link

codspeed-hq bot commented May 15, 2025

CodSpeed Performance Report

Merging #87 will degrade performances by 83.17%

Comparing defi-wonderland:fix/solar-span-too-tight (a51e2ca) with fix-solar-differences (523ed62)

Summary

❌ 4 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
parse_solar[test-data/BasicSample.sol] 404.5 µs 1,767.5 µs -77.11%
parse_solar[test-data/InterfaceSample.sol] 182 µs 396.3 µs -54.08%
parse_solar[test-data/LibrarySample.sol] 154.3 µs 286.1 µs -46.07%
parse_solar[test-data/ParserTest.sol] 565.8 µs 3,362.7 µs -83.17%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant