-
Notifications
You must be signed in to change notification settings - Fork 0
feat(devicebrowser): show enabled and readonly status #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
deactivating device through widget first time (second time no error) triggers this error: (probably not related to this PR and it is general bug with DeviceBrowser) Traceback (most recent call last):
File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/utils/error_popups.py", line 126, in wrapper
return method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/widgets/services/device_browser/device_item/device_item.py", line 175, in _reload_config
self.set_display_config(self.dev[self.device]._config)
~~~~~~~~^^^^^^^^^^^^^
File "/Users/janwyzula/PSI/bec/bec_lib/bec_lib/devicemanager.py", line 100, in __getitem__
return super().__getitem__(item)
^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'samy' |
883b033 to
45f08d1
Compare
|
@wyzula-jan fixed that error, CI cross is just from the docs build timing out |
283423d to
c8b10d9
Compare
c8b10d9 to
5e5edad
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
5e5edad to
c170cc7
Compare
Adds an icon (with tooltip) to show device enabled status and readonly status in the condensed form in the device browser. Fixes #788
Also fixes a bug where config is attempted to be reloaded while the device doesn't exist. ( Fixes #827 )