Skip to content

Conversation

@d-perl
Copy link
Contributor

@d-perl d-perl commented Jul 21, 2025

Adds an icon (with tooltip) to show device enabled status and readonly status in the condensed form in the device browser. Fixes #788

Also fixes a bug where config is attempted to be reloaded while the device doesn't exist. ( Fixes #827 )

@d-perl d-perl requested review from cappel89 and wyzula-jan July 21, 2025 14:27
@d-perl d-perl self-assigned this Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...services/device_browser/device_item/device_item.py 88.88% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@wyzula-jan
Copy link
Contributor

deactivating device through widget first time (second time no error) triggers this error:

(probably not related to this PR and it is general bug with DeviceBrowser)

Traceback (most recent call last):
  File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/utils/error_popups.py", line 126, in wrapper
    return method(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/janwyzula/PSI/bec_widgets/bec_widgets/widgets/services/device_browser/device_item/device_item.py", line 175, in _reload_config
    self.set_display_config(self.dev[self.device]._config)
                            ~~~~~~~~^^^^^^^^^^^^^
  File "/Users/janwyzula/PSI/bec/bec_lib/bec_lib/devicemanager.py", line 100, in __getitem__
    return super().__getitem__(item)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'samy'

@d-perl
Copy link
Contributor Author

d-perl commented Jul 30, 2025

@wyzula-jan fixed that error, CI cross is just from the docs build timing out

@d-perl d-perl force-pushed the feat/788_show_additional_info branch from 283423d to c8b10d9 Compare August 7, 2025 13:40
@d-perl d-perl force-pushed the feat/788_show_additional_info branch from c8b10d9 to 5e5edad Compare August 18, 2025 07:37
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 17, 2025
@d-perl d-perl force-pushed the feat/788_show_additional_info branch from 5e5edad to c170cc7 Compare October 17, 2025 12:03
@github-actions github-actions bot removed the Stale label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants