Skip to content

fix: allow restore on-demand mode database (#311) #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow restore on-demand mode database (#311) #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dynamodump/dynamodump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ def prepare_gsi_for_restore(gsi, billing_mode):
"Projection": gsi["Projection"],
}

if billing_mode != PAY_PER_REQUEST_BILLING_MODE:
if billing_mode != PAY_PER_REQUEST_BILLING_MODE and "ProvisionedThroughput" in gsi:
result["ProvisionedThroughput"] = prepare_provisioned_throughput_for_restore(
gsi["ProvisionedThroughput"]
)
Expand Down Expand Up @@ -900,6 +900,9 @@ def do_restore(
original_gsi_read_capacities = []
if table_global_secondary_indexes is not None:
for gsi in table_global_secondary_indexes:
if "ProvisionedThroughput" not in gsi:
continue

# keeps track of original gsi write capacity units. If provisioned capacity is 0, set to
# RESTORE_WRITE_CAPACITY as fallback given that 0 is not allowed for write capacities
original_gsi_write_capacity = gsi["ProvisionedThroughput"][
Expand Down Expand Up @@ -1065,6 +1068,9 @@ def do_restore(
if table_global_secondary_indexes is not None:
gsi_data = []
for gsi in table_global_secondary_indexes:
if "ProvisionedThroughput" not in gsi:
continue

wcu = gsi["ProvisionedThroughput"]["WriteCapacityUnits"]
rcu = gsi["ProvisionedThroughput"]["ReadCapacityUnits"]
original_gsi_write_capacity = original_gsi_write_capacities.pop(0)
Expand Down