LCFS - Negative credit balance

[kevin-hashimoto]

• fix: negative credit balance due to balance calculations bug of reserved balances during assessment, fixes LCFS - Negative credit balance #3262

[github-actions]

Backend Test Results

1 267 tests   1 267 ✅  10m 36s ⏱️
   45 suites      0 💤
    1 files        0 ❌

Results for commit 6ad86fb.

♻️ This comment has been updated with latest results.

[github-actions]

Frontend Test Results

    1 files    292 suites   3m 7s ⏱️
4 706 tests 4 699 ✅ 7 💤 0 ❌
4 708 runs  4 701 ✅ 7 💤 0 ❌

Results for commit 6ad86fb.

♻️ This comment has been updated with latest results.

[AlexZorkin]

This is incorrect unfortunately. the agreement_date is just an arbitrary date for record keeping. The effective_date is what we need to be using and is the date the transfer is recorded by the Director.

[AlexZorkin]

Check the transaction logic on compliance report assessment and make sure we never give credits in an amount that would put a suppliers balance negative.

If you want to look at transfer dates, this is the logic we should be using for inclusion:

Reporting Period Standardization

Default reporting year runs April 1 – March 31.
This cycle applies to all years after the initial submission year.

Initial Year Exception

The first submission year begins on January 1 and ends on March 31 to handle overlap.