DBC22-5037: List and manage organizations #23
Conversation
| <br /> | ||
| </React.Fragment> | ||
| )) | ||
| } |
There was a problem hiding this comment.
Allow multiple alerts to show separated by linebreak
ray-oxd
force-pushed
the
feature/DBC22-5037
branch
from
63660c4 to
cb29466
Compare
| {React.Children.map(children, child => | ||
| React.cloneElement(child, { submitting: submitting, setSubmitting: setSubmitting, setOpen: setOpen }) | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
shifting all tailwind classes to css since it doesn't work well with hot reload
ray-oxd
force-pushed
the
feature/DBC22-5037
branch
from
cb29466 to
80c3381
Compare
ray-oxd
force-pushed
the
feature/DBC22-5037
branch
from
80c3381 to
8e0ad7d
Compare
There was a problem hiding this comment.
Creating multiple organizations with the same name is possible if the case is varied (e.g., TMCC and tmcc). Name comparison should be case insensitive to prevent. See https://forum.djangoproject.com/t/how-to-make-field-case-insensitive/6918/8 for discussion
The edit ride user modal should prepopulate organization, role and superuser values with current values for the user. The superuser field should only be visible to a user with the superuser role already (and the backend should be verifying that only a superuser can promote another user to superuser).
|
|
||
| <div className={'ride-checkboxes-items'}> | ||
| {itemsList.map((item, index) => ( | ||
| <div key={item.label} className={'ride-checkboxes-items-row'}> |
There was a problem hiding this comment.
In my env, this seems to have caused a console error "installHook.js:1 Each child in a list should have a unique "key" prop.", which seems to mean that item.label is blank.
There was a problem hiding this comment.
Will use item.id instead.
| return ( | ||
| <div className="org-form"> | ||
| <div className={'container'}> | ||
| <RIDETextInput label={'Organization name:'} extraClasses={'mr-5 form'} value={name} handler={setName} maxLength={30} /> |
There was a problem hiding this comment.
The presence of .form in extraClasses seems to be causing a CSS render issue where the fields spill out to the right. This is catching the general .form class to be applied to each row. Is that necessary?
There was a problem hiding this comment.
Will rename to org-form. There are custom styling for this class in textinput.scss.
Will add case-insensitive validation to the serializer of the organizations view.
Missed renaming some props (initialValue -> value) - will be addressed.
OrganizationAPIView is gated behind "permission_classes = [permissions.IsAdminUser]" so only superusers can use this endpoint anyway. |
|
DBC22-5037
Story DBC22-4858