Add property for number of threads to blosc compressor. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear Patric, |
|
Hi, @pedson. Currently, jzarr is not under active development, and we at Zarr will be actively maintaining the library over here. I see that your PR has been taken care of here → zarr-developers#6, thanks, @joshmoore. We'll be doing a release soon with the changes in this PR. More details to follow. Thanks! Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property in the blosc compressor map for the number of threads argument passed to the blosc dll. This PR will only affect write operations where the user creates their own compressor as this is a fairly straighforward change.
Usage:
CompressorFactory.create("blosc", "cname", "zstd", "clevel", 1, "nthreads", 4);A second PR will contain a further update that allows for setting the number of threads when a read operation is creating the compressor automatically. This is slightly more invasive and could be accomplished in more than one way.