bbPress Akismet orphan postmeta cleanup infinite loop fix #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
In trunk, for 2.7. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7268 9866e705-20ec-0310-96e7-cbb4277adcfb
git-svn-id: https://bbpress.svn.wordpress.org/trunk@7269 9866e705-20ec-0310-96e7-cbb4277adcfb
From 2.6.11. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7275 9866e705-20ec-0310-96e7-cbb4277adcfb
This change prevents post title hints from being prepended to titles of Forums, Topics, or Replies, which was happening as a consequence of calling `get_the_title()` which assumes every protected/private post title needs it. It does this by including the following code changes: * introduce the `bbp_no_title_status_hints()` filter function, which hooks into 2 WordPress filters and maybe overrides the return value * replace a few `get_the_title()` calls with `get_post_field( 'post_title' )` to bypass the above filters when they would never be desirable Committer note: this could be considered a small back-compat break (because it alters long-standing theme-side output) but ultimately it is a design decision to output all of the forum content as it was saved by the community members. Forums that prefer the old behavior can unhook `bbp_no_title_status_hints` and continue to customize child template parts to insert custom forum status hints. Fixes #3602. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7276 9866e705-20ec-0310-96e7-cbb4277adcfb
This change prevents the Forum Archive page from appearing a second time in the breadcrumb trail when using pages, shortcodes, and/or subpages for forum setup. It does this by keeping track of a previous match of a page by path to the Forum Archive, and skipping that page ID in the subsequent ancestors loop. In trunk, for 2.7. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7277 9866e705-20ec-0310-96e7-cbb4277adcfb
This change checks posts for shortcode usages and adds "state" labels for them, to help make Forum integration easier to identify from within the list table context (usually Pages, but currently not post-type specific). It does this by introducing `BBP_Admin::display_post_states()` and hooking it in as a filter to `display_post_states`. Committer note: `get_page_by_path()` would offer more precision but also be significantly more costly to call here, so instead there is a fuzzy match on `post_name` for the Forum & Topic Archive pages only. Fixes #3605. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7278 9866e705-20ec-0310-96e7-cbb4277adcfb
This change ensures that features like Subscriptions & Pagination (inside of topics list loops) have: an opportunity to use the anticipated function path, and access to the right filters when including links back to them. This fixes a potential bug where filtering a topic permalink would not happen inside of emails or pagination in the loop-topic template part. See #3603. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7279 9866e705-20ec-0310-96e7-cbb4277adcfb
This change ensures that the correct public statuses are used by default inside of the `bbp_has_search_results()` function, and it does this by using the values from `bbp_get_public_topic_statuses()` and not the keys. This fixes a regression causing search results to omit public statuses as part of their default arguments. Props GDragoN. Fixes #3607. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7280 9866e705-20ec-0310-96e7-cbb4277adcfb
This change tweaks the code commentary a bit, and adds a default value of an empty array. This is largely for the sake of code cleanliness, but also removes the potential for debug notices or errors inside of the magic methods from `data` not being initialized as an array when they are first called. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7281 9866e705-20ec-0310-96e7-cbb4277adcfb
This method was removed long ago, and replaced by the `bbp_setup_globals` sub-action. git-svn-id: https://bbpress.svn.wordpress.org/trunk@7282 9866e705-20ec-0310-96e7-cbb4277adcfb
This change: * swaps in `terser` & `@wordpress/stylelint-config` * updates stylelint to 15.11.0 (with `scss` support) * adds separate stylelint config files for both CSS and SCSS (and deletes the original auto-loaded `.stylelintrc` file) This is just enough to get Grunt unclogged and working again without complaining too much. ---- To make this work: * Recommend to install NVM to make using npm 18 easier * `nvm use 18` * `npm install --legacy-peer-deps --save-dev` Once complete, the various `grunt` CLI commands should work again without any problems (for now!) git-svn-id: https://bbpress.svn.wordpress.org/trunk@7283 9866e705-20ec-0310-96e7-cbb4277adcfb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bbpress.trac.wordpress.org/ticket/3580
https://bbpress.trac.wordpress.org/ticket/3588