improvements for blending functions such that bleeding with background clearColor is avoided #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d clearColor is avoided
PTaylour
reviewed
Jan 15, 2019
|
@munwaikong any update on this? Not essential, but I'd like to try and get tests in place for visible changes |
|
Hi yes - apologies for the delay. <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Video Context Playground</title>
</head>
<body>
<h4>EffectNode Test</h4>
<canvas id="canvas" width="640" height="360"></canvas>
<h4>CompositionNode Test</h4>
<canvas id="canvas2" width="640" height="360"></canvas>
<h4>Alpha Control</h4>
<input id="timecontrol" type="range" min=0 max=100 />
<section id="controls">
<button type="button" id="play">Play</button>
<button type="button" id="pause">Pause</button>
</section>
<script src="http://bbc.github.io/VideoContext/dist/videocontext.js"></script>
<!-- <script src="../dist/videocontext.js"></script> -->
<script>
const canvas = document.getElementById(`canvas`);
const timecontrol = document.getElementById(`timecontrol`);
const playBtn = document.getElementById(`play`);
const pauseBtn = document.getElementById(`pause`);
const video1 = `http://bbc.github.io/VideoContext/assets/introductions-rant.mp4`;
<!-- EffectNode Test -->
const vc = new VideoContext(canvas);
const nodeA = vc.video(video1, 12);
const nodeB = vc.video(video1, 14);
nodeA.start(0);
nodeA.stop(10);
nodeB.start(0);
nodeB.stop(10);
const opacityEffectB = vc.effect(VideoContext.DEFINITIONS.OPACITY);
opacityEffectB.opacity = 0.5;
nodeB.connect(opacityEffectB);
nodeA.connect(vc.destination);
opacityEffectB.connect(vc.destination);
<!-- CompositorNode Test -->
const vc2 = new VideoContext(canvas2);
const node2A = vc2.video(video1, 12);
const node2B = vc2.video(video1, 14);
node2A.start(0);
node2A.stop(10);
node2B.start(0);
node2B.stop(10);
const opacityEffect2B = vc2.effect(VideoContext.DEFINITIONS.OPACITY);
opacityEffect2B.opacity = 0.5;
node2B.connect(opacityEffect2B);
const compositor2A = vc2.compositor(VideoContext.DEFINITIONS.COMBINE);
node2A.connect(vc2.destination);
opacityEffect2B.connect(compositor2A);
compositor2A.connect(vc2.destination);
// --
playBtn.addEventListener(`click`, () => {vc.play();vc2.play();});
pauseBtn.addEventListener(`click`, () => {vc.pause();vc2.play();});
timecontrol.addEventListener(`input`, evt => {
const val = evt.target.value;
opacityEffectB.opacity = val / 100;
opacityEffectB._render();
opacityEffect2B.opacity = val / 100;
opacityEffect2B._render();
});
</script>
</body>
</html>Using that test page you can play with the slider to adjust the Opacity (EffectNode) from opacity 0->1. Notice that dip to dark when you change opacity which is not expected - this occurs however due to the opacity blending with the clearColor (rbga(0,0,0,0)) |
|
@PTaylour did you manage to replicate and see the differences? |
|
Apologies for the delay, I'm have a regression testing session right now. Shall check! |
|
New and improved regression testing now merged. I'll have a go at writing a test for your case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.