Upgrade chicory to 1.5.1 #26976
Closed
Upgrade chicory to 1.5.1 #26976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
dzbarsky
force-pushed
the
zbarsky/chicory
branch
2 times, most recently
from
42d0967 to
70f0402
Compare
dzbarsky
commented
Sep 12, 2025
| build --java_language_version=21 | ||
| build --tool_java_language_version=21 | ||
| build --tool_java_runtime_version=21 | ||
| # Don't depend on a JAVA_HOME pointing at a system JDK |
There was a problem hiding this comment.
I believe we can upgrade rules_jvm_external instead of doing this to make it unnecessary; I can do so in a separate PR
dzbarsky
force-pushed
the
zbarsky/chicory
branch
from
70f0402 to
8158788
Compare
|
@dzbarsky Could you please take a look at the failing checks? |
bharadwaj08-one
added
awaiting-user-response
|
@dzbarsky perhaps just rebasing and rerunning the tests helps? |
|
Converting to draft for now, chicory upstream is planning to make more changes to help us #26975 (comment) |
|
Fixed in #27186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.