feat: update boost.thread in boost libraries 1.87.0 #6107

wep21 · 2025-10-06T12:10:17Z

update boost thread introduced by feat: update boost thread 1.87.0 #6099

bazel-io · 2025-10-06T12:10:34Z

Hello @Vertexwahn, @vtsao-openai, modules you maintain (boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

wep21 · 2025-10-06T12:11:01Z

@bazel-io skip_check unstable_url

gemini-code-assist

Code Review

This pull request adds a new version 1.87.0.bcr.2 for the boost.test module, primarily to update its dependency on boost.thread. The review identified two critical issues that need to be addressed. First, there is a version mismatch in the MODULE.bazel file where the version should be 1.87.0.bcr.2. Second, the presubmit.yml file contains duplicate task names, which is invalid YAML and will cause presubmit jobs to be skipped.

gemini-code-assist · 2025-10-06T12:11:16Z

modules/boost.test/1.87.0.bcr.2/MODULE.bazel

@@ -0,0 +1,30 @@
+module(
+    name = "boost.test",
+    version = "1.87.0.bcr.1",


The module version 1.87.0.bcr.1 does not match the directory version 1.87.0.bcr.2. Please update the version to match the directory path to ensure consistency and prevent potential resolution issues.

Suggested change

version = "1.87.0.bcr.1",

version = "1.87.0.bcr.2",

modules/boost.test/1.87.0.bcr.2/presubmit.yml

bazel-io · 2025-10-06T12:17:01Z

Hello @vtsao-openai, @Vertexwahn, modules you maintain (boost.lockfree, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:17:02Z

Hello @bazelbuild/bcr-maintainers, modules (boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:33:00Z

Hello @vtsao-openai, modules you maintain (boost.lockfree, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:33:00Z

Hello @Vertexwahn, modules you maintain (boost.lockfree, boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:33:01Z

Hello @bazelbuild/bcr-maintainers, modules (boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:35:52Z

Hello @Vertexwahn, modules you maintain (boost.lockfree, boost.property_tree, boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:35:53Z

Hello @bazelbuild/bcr-maintainers, modules (boost.property_tree, boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:39:42Z

Hello @Vertexwahn, modules you maintain (boost.lockfree, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:39:43Z

Hello @bazelbuild/bcr-maintainers, modules (boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:39:44Z

Hello @lalten, modules you maintain (boost.log) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:42:38Z

Hello @Vertexwahn, modules you maintain (boost.lockfree, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:42:39Z

Hello @bazelbuild/bcr-maintainers, modules (boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:46:30Z

Hello @bazelbuild/bcr-maintainers, modules (boost.graph, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:46:31Z

Hello @Vertexwahn, modules you maintain (boost.graph, boost.lockfree, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:49:09Z

Hello @bazelbuild/bcr-maintainers, modules (boost.geometry, boost.graph, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-06T12:49:10Z

Hello @Vertexwahn, modules you maintain (boost.geometry, boost.graph, boost.lockfree, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

wep21 · 2025-10-06T14:41:04Z

@fmeum @meteorcloudy I appreciate it if you could add presubmit auto run tag to run ci.

bazel-io

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

wep21 · 2025-10-06T23:16:01Z

error comes from boostorg/interprocess#258.
I will also add patch for interprocess.

Require module maintainers' approval for newly pushed changes.

bazel-io · 2025-10-07T10:42:22Z

Hello @bazelbuild/bcr-maintainers, modules (boost.geometry, boost.graph, boost.interprocess, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io · 2025-10-07T10:42:23Z

Hello @Vertexwahn, modules you maintain (boost.geometry, boost.graph, boost.interprocess, boost.lockfree, boost.log, boost.property_tree, boost.serialization, boost.spirit, boost.test, boost.xpressive) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Signed-off-by: wep21 <[email protected]>

wep21 · 2025-10-07T23:45:30Z

@fmeum @meteorcloudy ready to review

bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Oct 6, 2025

gemini-code-assist bot reviewed Oct 6, 2025

View reviewed changes

wep21 force-pushed the update-boost-thread-deps branch from 336860b to bd422f9 Compare October 6, 2025 12:12

fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 6, 2025

vtsao-openai previously approved these changes Oct 6, 2025

View reviewed changes

bazel-io previously approved these changes Oct 6, 2025

View reviewed changes

wep21 added 13 commits October 7, 2025 21:17

update boost.thread in boost.test 1.87.0

0b2a164

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.lockfree 1.87.0

bfdc23a

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.spirit 1.87.0

46de51f

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.serialization 1.87.0

c246976

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.property_tree 1.87.0

80ef14d

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.log 1.87.0

ddde919

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.xpressive 1.87.0

eb7e0fa

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.graph 1.87.0

112fc09

Signed-off-by: wep21 <[email protected]>

update boost.thread in boost.geometry 1.87.0

9205ec8

Signed-off-by: wep21 <[email protected]>

fix

bb30be1

Signed-off-by: wep21 <[email protected]>

update boost interprocess

3df433c

Signed-off-by: wep21 <[email protected]>

fix

b677287

Signed-off-by: wep21 <[email protected]>

update

e996f23

Signed-off-by: wep21 <[email protected]>

wep21 force-pushed the update-boost-thread-deps branch from 7a447d7 to e996f23 Compare October 7, 2025 12:17

wep21 added 2 commits October 8, 2025 07:18

update boost.test presubmit

463ddcc

Signed-off-by: wep21 <[email protected]>

update boost.test presubmit

fa31e7a

Signed-off-by: wep21 <[email protected]>

feat: update boost.thread in boost libraries 1.87.0 #6107

Are you sure you want to change the base?

feat: update boost.thread in boost libraries 1.87.0 #6107

Conversation

wep21 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

wep21 commented Oct 6, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

bazel-io commented Oct 6, 2025

Uh oh!

wep21 commented Oct 6, 2025

Uh oh!

bazel-io left a comment

Choose a reason for hiding this comment

Uh oh!

wep21 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bazel-io commented Oct 7, 2025

Uh oh!

bazel-io commented Oct 7, 2025

Uh oh!

wep21 commented Oct 7, 2025

Uh oh!

Uh oh!

wep21 commented Oct 6, 2025 •

edited

Loading

wep21 commented Oct 6, 2025 •

edited

Loading