Skip to content

[email protected] #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[email protected] #6104

wants to merge 3 commits into from
+208 −23

Conversation

Vertexwahn
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Oct 5, 2025

Hello @kekxv, modules you maintain (boost.mysql) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 5, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.89.0 for the boost.mysql module. The overall structure is correct for a Bazel Central Registry submission. However, I've identified a critical issue and a high-severity issue in the MODULE.bazel file. There is an incorrect dependency on rules_cc which will cause builds to fail, and the specified bazel_compatibility version is likely a typo and is overly restrictive. I have provided code suggestions to resolve these issues.

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check compatibility_level

@bazel-io bazel-io added skip-url-stability-check Skip the URL stability check for the PR skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel labels Oct 5, 2025
bazel-io
bazel-io approved these changes Oct 5, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazel-io bazel-io bazel-io approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vertexwahn @bazel-io @Wyverald