Skip to content

[email protected] #6100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #6100

wants to merge 1 commit into from
+325 −1

Conversation

aspect-marvin
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Oct 4, 2025

Hello @alexeagle, @gregmagolan, @jbedard, modules you maintain (aspect_rules_js) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 2.6.1 of the aspect_rules_js module. The changes are consistent with the requirements for adding a new module version to the Bazel Central Registry, including the addition of the MODULE.bazel file, source information, presubmit configuration, and updating the metadata.json. The submission adheres to the BCR style guide, and I have not found any issues requiring changes.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aspect-marvin @bazel-io @Wyverald @alexeagle