-
-
Couldn't load subscription status.
- Fork 11
feat: Introduces a new target_tar_toolchain_type #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduces a new target_tar_toolchain_type #65
Conversation
Introduces target_type toolchain alongside the existing exec-based type, allowing tar operations to be resolved based on target platform. Also adds resolved_target_toolchain for direct toolchain access in genrules. Includes test to validate functionality.
d218fb3 to
e3d204c
Compare
|
|
The CI failure is unrelated, but please add |
|
@fmeum Thanks, already done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could call target_type runtime_type, but I'm not sure whether that's clearly better.
We may need to update awk to get past the outage.
Although I prefer target type more as it illustrates direct connection with |
|
Yeah, let's keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!


This PR is a follow-up to bazel-contrib/bazel-lib#1180 which is supposed to help with the issue described in bazel-contrib/rules_oci#769. The description of the issue and proposal are in bazel-contrib/rules_oci#844 PR.
CC @alexeagle @fmeum