Skip to content

Conversation

@sfc-gh-dbieliaiev
Copy link
Contributor

This PR is a follow-up to bazel-contrib/bazel-lib#1180 which is supposed to help with the issue described in bazel-contrib/rules_oci#769. The description of the issue and proposal are in bazel-contrib/rules_oci#844 PR.

CC @alexeagle @fmeum

Introduces target_type toolchain alongside the existing exec-based type,
allowing tar operations to be resolved based on target platform. Also adds
resolved_target_toolchain for direct toolchain access in genrules.

Includes test to validate functionality.
@sfc-gh-dbieliaiev sfc-gh-dbieliaiev force-pushed the dbieliaiev-target-tar-toolchain branch from d218fb3 to e3d204c Compare October 1, 2025 07:45
@aspect-workflows
Copy link

aspect-workflows bot commented Oct 1, 2025

Test (Bazel 7.x) (Test)

All tests were cache hits

23 tests (100.0%) were fully cached saving 3s.


Test (Bazel 8.x) (Test)

All tests were cache hits

23 tests (100.0%) were fully cached saving 1s.


Test (Bazel 9.x) (Test)

All tests were cache hits

23 tests (100.0%) were fully cached saving 1s.


Test (Bazel 7.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.


Test (Bazel 8.x) (Test)

e2e/smoke

⚠️ Buildkite build #159 failed.


Test (Bazel 9.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 45ms.


Test (WORKSPACE) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test (Bazel 7.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 135ms.


Test (Bazel 8.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 158ms.


Test (Bazel 9.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 330ms.

@sfc-gh-dbieliaiev sfc-gh-dbieliaiev changed the title Introduces a new target_tar_toolchain_type. feat: Introduces a new target_tar_toolchain_type Oct 1, 2025
@fmeum
Copy link
Member

fmeum commented Oct 1, 2025

The CI failure is unrelated, but please add feat: to the PR title.

@sfc-gh-dbieliaiev
Copy link
Contributor Author

@fmeum Thanks, already done

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could call target_type runtime_type, but I'm not sure whether that's clearly better.

We may need to update awk to get past the outage.

@sfc-gh-dbieliaiev
Copy link
Contributor Author

We could call target_type runtime_type, but I'm not sure whether that's clearly better.

We may need to update awk to get past the outage.

Although I prefer target type more as it illustrates direct connection with target_compatible_with attribute, generally I don't mind changing, so please let me know if the decision is final.

@fmeum
Copy link
Member

fmeum commented Oct 1, 2025

Yeah, let's keep target_type for precisely that reason.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 2637ebb into bazel-contrib:main Oct 2, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants