Skip to content

Add validation that tags exist, fix StepFunctions service name, fix docdb to retrieve and post as clusters #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add validation that tags exist, fix StepFunctions service name, fix docdb to retrieve and post as clusters #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae3fd2
Add validation that tags exist, fix StepFunctions service name
mitchclarkebase2 May 21, 2025
9fb92fc
Fix docdb to retrieve and post as clusters
mitchclarkebase2 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions lib/services/docdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ def __init__(self, region):

def get_resources(self):
try:
client = boto3.client('rds', region_name=self.region)
paginator = client.get_paginator('describe_db_instances')
client = boto3.client('docdb', region_name=self.region)
paginator = client.get_paginator('describe_db_clusters')
page_iterator = paginator.paginate()
instances = []
clusters = []
for page in page_iterator:
instances.extend([{
'id': item['DBInstanceIdentifier'],
'arn': item['DBInstanceArn'],
} for item in page['DBInstances'] if 'DBClusterIdentifier' in item and item['Engine'] == 'docdb'])
for instance in instances:
tags = client.list_tags_for_resource(ResourceName=instance['arn'])['TagList']
clusters.extend([{
'id': item['DBClusterIdentifier'],
'arn': item['DBClusterArn'],
} for item in page['DBClusters'] if 'DBClusterIdentifier' in item and item['Engine'] == 'docdb'])
for cluster in clusters:
tags = client.list_tags_for_resource(ResourceName=cluster['arn'])['TagList']
self.identifiers.extend([{
'id': instance['id'],
'id': cluster['id'],
'tags': [{
'key': t['Key'],
'value': t['Value']
Expand Down
4 changes: 2 additions & 2 deletions lib/services/ecs_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ def get_resources(self):
'ServiceName': item['serviceName'],
'Cluster': clusterName
},
'tags': item['tags']
'tags': item['tags'] if 'tags' in item else []
} for item in client.describe_services(cluster=clusterName, services=array, include=['TAGS'])['services'])
else:
self.identifiers.extend({
'id': {
'ServiceName': item['serviceName'],
'Cluster': clusterName
},
'tags': item['tags']
'tags': item['tags'] if 'tags' in item else []
} for item in client.describe_services(cluster=clusterName, services=serviceArns, include=['TAGS'])['services'])

except Exception as e:
Expand Down
2 changes: 1 addition & 1 deletion lib/services/stepfunctions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def __init__(self, region):
self.identifiers = []
self.templates = {
'cfn-monitor': 'Stepfunctions',
'cfn-guardian': 'Stepfunctions'
'cfn-guardian': 'StepFunctions'
}
self.get_resources()

Expand Down