Skip to content

Conversation

qoog
Copy link

@qoog qoog commented Sep 17, 2025

Summary

Fixed type mismatches for get and set methods:

  • get now returns null instead of undefined to match string | null.
  • set now accepts a single string argument, even if the body is empty.
    These changes prevent TypeScript errors and ensure the API aligns with its type definitions.

How did you test your changes?

TypeScript compilation passes without errors. Verified that get and set calls behave as expected in the consuming code.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants